Skip to content

Check for number of input columns in concat transform - #3809

Merged
abgoswam merged 1 commit into
dotnet:masterfrom
abgoswam:abgoswam/concat_noinputcols
Jun 3, 2019
Merged

Check for number of input columns in concat transform#3809
abgoswam merged 1 commit into
dotnet:masterfrom
abgoswam:abgoswam/concat_noinputcols

Conversation

@abgoswam

@abgoswam abgoswam commented Jun 3, 2019

Copy link
Copy Markdown
Member

Fixes #3061

The PR makes the following changes:

  • Follows Solution A mentioned in the issue
  • Added a unit test

@abgoswam
abgoswam requested review from artidoro and codemzs June 3, 2019 19:26

@Ivanidzo4ka Ivanidzo4ka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:


try
{
var pipe = ML.Transforms.Concatenate("Features");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concatenate [](start = 41, length = 11)

maybe it make sense to remove params from inputColumnNames in Concatenate method?

@najeeb-kazmi najeeb-kazmi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@abgoswam
abgoswam merged commit 2ddb9ee into dotnet:master Jun 3, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Null Reference Exception when Concatenating with a single value

4 participants