Added tests for new API where components(Loaders/Transforms/Learners) are directly instantiated. - #468
Merged
Merged
Conversation
… are directly instantiated.
zeahmed
requested review from
Ivanidzo4ka,
TomFinley,
codemzs,
glebuk and
shauheen
July 2, 2018 17:44
Contributor
|
I wonder if we wanted to keep it (at least while we're working) in a separate folder from the usual "scenarios" folder, so as to keep these "in progress improvement" things in a conceptually distinct location. #Pending |
Member
codemzs
approved these changes
Jul 2, 2018
codemzs
left a comment
codemzs
left a comment
Member
There was a problem hiding this comment.
This is awesome! Looks great and not too different from what we had except functionally it is solid!
Contributor
Author
|
Yes, I am moving to new folder so these tests are separate from previous ones. In reply to: 401920469 [](ancestors = 401920469) |
eerhardt
pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
… are directly instantiated. (dotnet#468) * Added tests for new API where components(Loaders/Transforms/Learners) are directly instantiated. * Moved new tests to separate folder.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addressed #424.
Two scenario tests were added to show how to directly instantiate ML.NET components instead of using Pipeline API. The test may not look elegant at first instance but they will help us shape the new API.
This work is inline with new API proposal #371.