Skip to content

Check exception status even if TF_SessionRun throws an exception - #4755

Merged
harishsk merged 1 commit into
dotnet:masterfrom
sharwell:check-status
Feb 6, 2020
Merged

Check exception status even if TF_SessionRun throws an exception#4755
harishsk merged 1 commit into
dotnet:masterfrom
sharwell:check-status

Conversation

@sharwell

Copy link
Copy Markdown
Contributor

Extracted from #4569

@sharwell
sharwell requested a review from a team as a code owner January 31, 2020 19:47

@frank-dong-ms-zz frank-dong-ms-zz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sharwell

Copy link
Copy Markdown
Contributor Author

📝 Note that this is nice in general, but for the exception case we hit there is still no additional information about the crash. 😦

@antoniovs1029 antoniovs1029 added the test related to tests label Feb 4, 2020
@harishsk
harishsk merged commit ff320b8 into dotnet:master Feb 6, 2020
@sharwell

sharwell commented Feb 6, 2020

Copy link
Copy Markdown
Contributor Author

@antoniovs1029 I'm removing this test label since this is a production code change.

@sharwell sharwell removed the test related to tests label Feb 6, 2020
@sharwell
sharwell deleted the check-status branch February 6, 2020 13:16
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants