TextNormalizing export to Onnx - #4781
Merged
Merged
Conversation
kere-nel
commented
Feb 4, 2020
kere-nel
commented
Contributor
- can, at the moment, only handle case changing options
ganik
reviewed
Feb 5, 2020
| var isCaseChange = (_parent._caseMode == TextNormalizingEstimator.CaseMode.Lower) ? "LOWER" : | ||
| (_parent._caseMode == TextNormalizingEstimator.CaseMode.Upper) ? "UPPER" : "NONE"; | ||
| node.AddAttribute("case_change_action", isCaseChange); | ||
| } |
Contributor
There was a problem hiding this comment.
If its 'None' there is no need for the 'StringNormalizer' node at all
Contributor
Author
There was a problem hiding this comment.
Well, in the case that we are able to add the other options in the future, it would make sense to keep the option to pass "None". What do you think?
harishsk
reviewed
Feb 5, 2020
harishsk
reviewed
Feb 6, 2020
harishsk
approved these changes
Feb 6, 2020
kere-nel
force-pushed
the
onnx_text_normalizing
branch
from
February 12, 2020 18:43
9660423 to
2e11361
Compare
harishsk
reviewed
Feb 12, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.