Update to Microsoft.CodeAnalysis 3.3.1 - #4798
Merged
Merged
Conversation
Member
|
Tagging @JakeRadMSFT, since this affects Microsoft.ML.CodeGenerator, which is used by the CLI and VS Model Builder. |
Contributor
Author
|
@eerhardt I only intended to make the change for the code analyzers. I'm happy to restrict it if you aren't ready to update the code generator. However, if the code generator only works in Roslyn 3.3+ scenarios anyways (for other reasons), then it wouldn't hurt to make the change. |
sharwell
force-pushed
the
update-code-analysis
branch
from
February 6, 2020 22:00
664eb45 to
5466048
Compare
Contributor
Author
|
@eerhardt this pull request no longer alters the code generator dependencies |
Contributor
Author
|
@harishsk for review |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.