Skip to content

Enable RS1025 (Configure generated code analysis) #4800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharwell merged 1 commit into from
Feb 13, 2020
Merged

Enable RS1025 (Configure generated code analysis) #4800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ dotnet_diagnostic.VSTHRD103.severity = none
# VSTHRD200: Use "Async" suffix for async methods
dotnet_diagnostic.VSTHRD200.severity = none

# RS1025: Configure generated code analysis
dotnet_diagnostic.RS1025.severity = none

# RS1026: Enable concurrent execution
dotnet_diagnostic.RS1026.severity = none

Expand Down
3 changes: 3 additions & 0 deletions tools-local/Microsoft.ML.InternalCodeAnalyzer/BestFriendAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ public sealed class BestFriendAnalyzer : DiagnosticAnalyzer

public override void Initialize(AnalysisContext context)
{
// This analyzer reports violations in all code (including generated code)
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);

context.RegisterSemanticModelAction(Analyze);
}

Expand Down