Skip to content

Implement MSML_RelaxTestNaming suppressor for VSTHRD200 - #4803

Merged
sharwell merged 3 commits into
dotnet:masterfrom
sharwell:relax-test-names
Feb 14, 2020
Merged

Implement MSML_RelaxTestNaming suppressor for VSTHRD200#4803
sharwell merged 3 commits into
dotnet:masterfrom
sharwell:relax-test-names

Conversation

@sharwell

@sharwell sharwell commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

Allow asynchronous test methods to omit the 'Async' suffix.

@sharwell
sharwell marked this pull request as ready for review February 13, 2020 15:34
@sharwell
sharwell requested a review from a team as a code owner February 13, 2020 15:34
@sharwell

Copy link
Copy Markdown
Contributor Author

@harishsk for reviews

@sharwell

Copy link
Copy Markdown
Contributor Author

Or @justinormont

@harishsk

Copy link
Copy Markdown
Contributor

Is this PR to allow tests that have await calls within them to not be forced to have an Async suffix for the function name?

Also, can you please resolve the merge conflicts?

@sharwell

Copy link
Copy Markdown
Contributor Author

Is this PR to allow tests that have await calls within them to not be forced to have an Async suffix for the function name?

Yes, that is correct.

@sharwell
sharwell merged commit 0b4b15b into dotnet:master Feb 14, 2020
@sharwell
sharwell deleted the relax-test-names branch February 14, 2020 14:24
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants