Added in DateTime type support for TimeSeriesImputer - #4812
Merged
Conversation
yaeldekel
reviewed
Feb 10, 2020
This should be updated. Also, it should match the types in the table below. Refers to: src/Microsoft.ML.Featurizers/TimeSeriesImputer.cs:66 in 99a5eb3. [](commit_id = 99a5eb3, deletion_comment = False) |
natke
reviewed
Feb 10, 2020
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
natke
reviewed
Feb 11, 2020
eerhardt
reviewed
Feb 11, 2020
eerhardt
reviewed
Feb 11, 2020
Member
|
Any chance you can update the samples to use a |
natke
self-requested a review
February 26, 2020 00:13
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in System.DateTime support for the Date column in TimeSeriesImputer.
Internally it converts it to POSIX time before it sends it to the native implementation, and then converts it back to System.DateTime for the IDataView.
Also added more comments and comments for the Enums.