Skip to content

enable 2 tests but skip running from x86 #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frank-dong-ms-zz merged 2 commits into from
Feb 22, 2020
Merged

enable 2 tests but skip running from x86 #4877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa92b38
reenable 2 tests but skip running from x86
frank-dong-ms-zz Feb 22, 2020
aaa6896
add comments so this can be found in task list
frank-dong-ms-zz Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions test/Microsoft.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,14 @@ public DnnImageFeaturizerTests(ITestOutputHelper helper) : base(helper)
}

[OnnxFact]
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
[Trait("Category", "SkipInCI")]
public void TestDnnImageFeaturizer()
{
//skip running for x86 as this test using too much memory (over 2GB limit on x86)
//and very like to hit memory related issue when running on CI
//TODO: optimized memory usage in related code and enable x86 test run
if (!Environment.Is64BitProcess)
return;

var samplevector = GetSampleArrayData();

var dataView = DataViewConstructionUtils.CreateFromList(Env,
Expand Down Expand Up @@ -125,12 +129,15 @@ public void OnnxFeaturizerWorkout()
}
}

// Onnx is only supported on x64 Windows
[OnnxFact]
//Skipping test temporarily. This test will be re-enabled once the cause of failures has been determined
[Trait("Category", "SkipInCI")]
public void TestOldSavingAndLoading()
{
//skip running for x86 as this test using too much memory (over 2GB limit on x86)
//and very like to hit memory related issue when running on CI
//TODO: optimized memory usage in related code and enable x86 run
if (!Environment.Is64BitProcess)
return;

var samplevector = GetSampleArrayData();

var dataView = ML.Data.LoadFromEnumerable(
Expand Down