fix LdaWorkoutEstimatorCore - #4927
Merged
frank-dong-ms-zz merged 2 commits intoMar 10, 2020
Merged
Conversation
mstfbl
reviewed
Mar 10, 2020
| @@ -729,7 +728,7 @@ public void LdaWorkoutEstimatorCore() | |||
| builder.AddColumn("F1V", NumberDataViewType.Single, data); | |||
| var srcView = builder.GetDataView(); | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Perhaps a comment can be added here that explains the need to reset the random number generator for each received document due to way that ML.NET and LdaNative utilize multiple threads differently, for future readability.
Contributor
Author
There was a problem hiding this comment.
mstfbl
approved these changes
Mar 10, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix LdaWorkoutEstimatorCore test.
resetRandomGenerator needs to be true here as multiple compare will be performed later.
In lda_engine, a queue of samples with size of (num_of_threads - 2) will be created at first, each time a compare is performed the internal status of one sample (random number: rng_) is changed, so if size of queue is smaller the number of compare performed (in local workstation we have 12 cores thus the issue is not reproduced), dirty data will be used again for calculation and cause issue. set resetRandomGenerator to true will reset the random number rng_ every time before lda calculation thus fix the issue.