Fix quotes on json - #516
Merged
Merged
Conversation
Ivanidzo4ka
reviewed
Jul 10, 2018
| var graphDef = ToEntryPointGraph(); | ||
|
|
||
| return new PipelineResultRow($"{{'Nodes' : [{graphDef.Graph.ToJsonString()}]}}", | ||
| return new PipelineResultRow($"{{\"Nodes\" : [{graphDef.Graph.ToJsonString()}]}}", |
Contributor
There was a problem hiding this comment.
"Nodes" [](start = 45, length = 9)
not huge fan of composing json strings manually, but I'm fine with this changes.
Contributor
|
Greetings @jwood803, what kind test were you looking to add? |
Contributor
Author
|
@justinormont Just one to show that it returns the correct JSON. It's probably overkill and not urgent to add as @TomFinley mentioned. Especially since this change doesn't do much with the functionality. |
eerhardt
pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #507.
Didn't see any impacted tests for this, but going to see about adding one.