Skip to content

Use APICompat from the SDK - #6399

Merged
ericstj merged 5 commits into
dotnet:mainfrom
ericstj:enableApiCompat
Oct 21, 2022
Merged

Use APICompat from the SDK#6399
ericstj merged 5 commits into
dotnet:mainfrom
ericstj:enableApiCompat

Conversation

@ericstj

@ericstj ericstj commented Oct 21, 2022

Copy link
Copy Markdown
Member

We're using the 7.0 RC2 SDK which has support for multiple assembly packages.

@tarekgh

tarekgh commented Oct 21, 2022

Copy link
Copy Markdown
Member
/Users/runner/work/1/s/Microsoft.ML.sln(1,1): error MSB4025: The project file could not be loaded. Data at the root level is invalid. Line 1, position 1.
  Determining projects to restore...
  Restored /Users/runner/work/1/s/src/Native/Native.proj (in 203 ms).

Build FAILED.

/Users/runner/work/1/s/Microsoft.ML.sln(1,1): error MSB4025: The project file could not be loaded. Data at the root level is invalid. Line 1, position 1.
    0 Warning(s)
    1 Error(s)

@ericstj

ericstj commented Oct 21, 2022

Copy link
Copy Markdown
Member Author

Yeah, fixing that.

@ericstj

ericstj commented Oct 21, 2022

Copy link
Copy Markdown
Member Author

This should be working now.

@codecov

codecov Bot commented Oct 21, 2022

Copy link
Copy Markdown

Codecov Report

Merging #6399 (1c09336) into main (60db8e8) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6399      +/-   ##
==========================================
+ Coverage   68.50%   68.52%   +0.01%     
==========================================
  Files        1165     1167       +2     
  Lines      246211   246617     +406     
  Branches    25744    25764      +20     
==========================================
+ Hits       168660   168985     +325     
- Misses      70865    70919      +54     
- Partials     6686     6713      +27     
Flag Coverage Δ
Debug 68.52% <ø> (+0.01%) ⬆️
production 62.93% <ø> (+<0.01%) ⬆️
test 88.92% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️
test/Microsoft.ML.Tests/ImagesTests.cs 91.79% <0.00%> (-6.21%) ⬇️
src/Microsoft.ML.ImageAnalytics/ImageGrayscale.cs 72.64% <0.00%> (-3.59%) ⬇️
src/Microsoft.ML.ImageAnalytics/ImageResizer.cs 72.05% <0.00%> (-3.12%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 25.38% <0.00%> (-1.53%) ⬇️
...rosoft.ML.ImageAnalytics/VectorToImageTransform.cs 75.83% <0.00%> (-0.72%) ⬇️
...Microsoft.ML.ImageAnalytics/ImagePixelExtractor.cs 72.22% <0.00%> (-0.40%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.38% <0.00%> (-0.15%) ⬇️
src/Microsoft.ML.ImageAnalytics/ImageType.cs 76.47% <0.00%> (ø)
...Microsoft.ML.AutoML.Tests/MLContextManagerTests.cs 100.00% <0.00%> (ø)
... and 10 more

@smasher164 smasher164 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelgsharp

Copy link
Copy Markdown
Contributor

@ericstj Target framework .NETStandard,Version=v2.0 is no longer supported in the latest version.

Also make sure we run API Compat even on non-stable packages.
They just won't have baseline validation.
@ericstj

ericstj commented Oct 21, 2022

Copy link
Copy Markdown
Member Author

@ericstj Target framework .NETStandard,Version=v2.0 is no longer supported in the latest version.

Yeah, that error was happening because we removed the empty assembly in c55727c#diff-fd2ae27a46a03c42f911d47f46937acbd3a2fa21214691de68fb89301652b1f2R6.

I've suppressed it since that removal doesn't actually impact customers: they'll still be able to install the package and it will provide all the same functionality.

@ericstj
ericstj merged commit 1903fa5 into dotnet:main Oct 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants