Skip to content

[release/5.0] Update mac build machines - #7560

Merged
ericstj merged 3 commits into
release/5.0from
backport/pr-7558-to-release/5.0
Nov 24, 2025
Merged

[release/5.0] Update mac build machines#7560
ericstj merged 3 commits into
release/5.0from
backport/pr-7558-to-release/5.0

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Backport of #7558 to release/5.0

/cc @ericstj

Update build machines to use supported MacOS image.

ericstj and others added 3 commits November 24, 2025 22:33

@rokonec rokonec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suppose we are fine than it now require macOS 13.0+ to run.

@ericstj
ericstj merged commit 82a8d00 into release/5.0 Nov 24, 2025
16 of 25 checks passed
@codecov

codecov Bot commented Nov 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.01%. Comparing base (d76abb7) to head (37f7871).
⚠️ Report is 1 commits behind head on release/5.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/5.0    #7560      +/-   ##
===============================================
- Coverage        69.02%   69.01%   -0.01%     
===============================================
  Files             1482     1482              
  Lines           274093   274093              
  Branches         28266    28266              
===============================================
- Hits            189199   189175      -24     
- Misses           77509    77531      +22     
- Partials          7385     7387       +2     
Flag Coverage Δ
Debug 69.01% <ø> (-0.01%) ⬇️
production 63.30% <ø> (-0.02%) ⬇️
test 89.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericstj

ericstj commented Nov 25, 2025

Copy link
Copy Markdown
Member

LGTM. I suppose we are fine than binaries will now require at least macOS 13.0 to run.

They did before, without this setting they defaulted to the build machine's version which was macOS 13.

@ericstj

ericstj commented Nov 25, 2025

Copy link
Copy Markdown
Member

Interesting that this auto-merged before build was complete. I think that means we need to make build-analysis a required check?

@ericstj

ericstj commented Nov 25, 2025

Copy link
Copy Markdown
Member

Interesting that this auto-merged before build was complete. I think that means we need to make build-analysis a required check?

Yes, that was it. We have different branch protection rules for release branch and it was missing the required checks policy. I fixed it.

@github-actions github-actions Bot locked and limited conversation to collaborators Dec 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants