Save ConvertTransform as ONNX Operator and Control the Use of Experimental Features with a Flag - #947
Merged
Merged
Conversation
1. Introduce a new argument to SaveOnnx, which is OnnxVersion. Two values are currently allowed, "Latest" and "Experimental". Note that "Latest" means that the produced ONNX model meets the latest ONNX release while "Experimental" may produce things not officially supported in ONNX. 2. For (1), the interface of saving ONNX is slightly changed. Now, CanSaveOnnx requires an OnnxContext as its input argument. 3. Add exporter for ConvertTransform. It doesn't use standard ONNX operator.
wschin
requested review from
Ivanidzo4ka,
Zruty0,
codemzs,
shauheen and
vaeksare
September 19, 2018 17:59
|
This PR does not reference an issue. Can you please file one and reference it in the PR description? #Resolved |
Contributor
Author
|
@markusweimer , sure. Thanks for reminding. #Resolved |
Ivanidzo4ka
reviewed
Sep 21, 2018
Contributor
|
Can you make sure it pass build system? #Resolved |
justinormont
reviewed
Oct 2, 2018
justinormont
reviewed
Oct 2, 2018
Ivanidzo4ka
reviewed
Oct 9, 2018
Ivanidzo4ka
reviewed
Oct 9, 2018
Ivanidzo4ka
reviewed
Oct 9, 2018
Ivanidzo4ka
reviewed
Oct 9, 2018
Contributor
|
Looks like there's a test which failed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two values are currently allowed, "Latest" and "Experimental".
Note that "Latest" means that the produced ONNX model meets
the latest ONNX release while "Experimental" may produce
things not officially supported in ONNX.
CanSaveOnnx requires an OnnxContext as its input argument,
because if a model can be saved to ONNX depends on the targeted
ONNX version now.
ONNX operator.
Related issue: #945