Keys in property list dictionaries aren't necessarily unique. Fixes xamarin-macios#5277. - #39
Merged
Conversation
…amarin-macios#5277. Fixes dotnet/macios#5277.
mandel-macaque
approved these changes
Dec 17, 2018
jstedfast
approved these changes
Dec 17, 2018
Member
|
Thanks for tackling this, @rolfbjarne |
spouliot
approved these changes
Dec 17, 2018
spouliot
left a comment
There was a problem hiding this comment.
are we sure the last entry wins (e.g. if used from Xcode) ?
or is it a best guess ?
it will solve the exception but it might not produce what's expected
Member
|
@spouliot in the reported case, both plist values are actually the same. But yea, I don't think we know - I think it's a best guess until we get a report where the values are different. Since it's apparently a bug in Apple's web server, it probably won't last long. |
Member
|
This is an example reported on StackOverflow: https://stackoverflow.com/questions/53794998/duplicate-key-in-provisioning-profile-causes-build-failure-error-msb4018/53796567#53796567 |
Member
Author
I tested it: $ cat text.plist
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>key</key>
<string>value</string>
<key>key</key>
<string>second value</string>
</dict>
</plist>
$ /usr/libexec/PlistBuddy -c "Print :key" ./text.plist
second value |
rolfbjarne
added a commit
to rolfbjarne/Xamarin.MacDev
that referenced
this pull request
Dec 17, 2018
…amarin-macios#5277. (dotnet#39) Fixes dotnet/macios#5277.
rolfbjarne
added a commit
to rolfbjarne/Xamarin.MacDev
that referenced
this pull request
Dec 17, 2018
…amarin-macios#5277. (dotnet#39) Fixes dotnet/macios#5277.
rolfbjarne
added a commit
that referenced
this pull request
Dec 17, 2018
…amarin-macios#5277. (#39) (#41) Fixes dotnet/macios#5277.
rolfbjarne
added a commit
that referenced
this pull request
Dec 17, 2018
…amarin-macios#5277. (#39) (#40) Fixes dotnet/macios#5277.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/macios#5277.