Skip to content

[registrar] Cache the System.Void type. #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spouliot merged 1 commit into from
Oct 28, 2016
Merged

[registrar] Cache the System.Void type. #1024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tools/common/StaticRegistrar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,8 +827,12 @@ protected override TypeReference GetReturnType (MethodDefinition method)
return method.ReturnType;
}

TypeReference system_void;
protected override TypeReference GetSystemVoidType ()
{
if (system_void != null)
return system_void;

// find corlib
AssemblyDefinition corlib = null;
AssemblyDefinition first = null;
Expand All @@ -847,7 +851,7 @@ protected override TypeReference GetSystemVoidType ()
}
foreach (var type in corlib.MainModule.Types) {
if (type.Namespace == "System" && type.Name == "Void")
return type;
return system_void = type;
}

throw new Exception ("Couldn't find System.Void");
Expand Down