Skip to content

Bump maccore. - #10427

Merged
rolfbjarne merged 4 commits into
dotnet:mainfrom
rolfbjarne:bump-maccore-xamarin-analysis
Jan 20, 2021
Merged

Bump maccore.#10427
rolfbjarne merged 4 commits into
dotnet:mainfrom
rolfbjarne:bump-maccore-xamarin-analysis

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

New commits in xamarin/maccore:

Diff: https://github.com/xamarin/maccore/compare/5133d2cea1c52fb783f64ab2ba97c760cf33f5f4..2d9f8a96856fbd40f13a8e57df9c3d23e69602fb

@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Jan 14, 2021
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ Tests failed on Build ❌

Tests failed on Build.

Test results

7 tests failed, 34 tests passed.

Failed tests

  • xammac tests/Mac Modern/Debug: Failed (Tests run: 2450 Passed: 2315 Inconclusive: 12 Failed: 4 Ignored: 131)
  • xammac tests/Mac Modern/Debug (all optimizations): Failed (Tests run: 1890 Passed: 1797 Inconclusive: 7 Failed: 4 Ignored: 89)
  • xammac tests/Mac Modern/Release: Failed (Tests run: 2447 Passed: 2311 Inconclusive: 12 Failed: 4 Ignored: 132)
  • xammac tests/Mac Modern/Release (all optimizations): Failed (Tests run: 1890 Passed: 1795 Inconclusive: 7 Failed: 4 Ignored: 91)
  • [xUnit] Mono Mac OS X BCL tests group 4/Mac Modern/Debug: Failed (No test log file was produced)
  • MSBuild tests/Integration: Failed (Execution failed with exit code 30)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 148)

Pipeline on Agent XAMBOT-1103'

@rolfbjarne

Copy link
Copy Markdown
Member Author

@pjcollins the xamarin-analysis changes fails to build for us:

Making all in analysis
/Library/Frameworks/Mono.framework/Versions/Current/bin/msbuild /p:Features=strict /m /nologo /verbosity:quiet ../../xamarin-macios/../xamarin-analysis/shared/Xamarin.Analysis/Xamarin.Analysis.csproj
/usr/local/share/dotnet/sdk/5.0.100-preview.6.20265.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(234,5): error NETSDK1004: Assets file '/Users/builder/azdo/_work/1/s/xamarin-analysis/shared/Xamarin.Analysis/obj/project.assets.json' not found. Run a NuGet package restore to generate this file. [/Users/builder/azdo/_work/1/s/xamarin-analysis/shared/Xamarin.Analysis/Xamarin.Analysis.csproj]
make[2]: *** [../../xamarin-macios/../xamarin-analysis/shared/Xamarin.Analysis/bin/Debug/Xamarin.Analysis.Tasks.dll] Error 1
make[1]: *** [all-recurse] Error 1
make: *** [all-recurse] Error 1

@pjcollins pjcollins added the do-not-merge Do not merge this pull request label Jan 15, 2021
@pjcollins

pjcollins commented Jan 15, 2021

Copy link
Copy Markdown
Member

I think we just need a /restore, I bumped this to test a new branch that we can merge to maccore if it fixes things.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ Tests failed on Build ❌

Tests failed on Build.

Test results

1 tests failed, 40 tests passed.

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

Pipeline on Agent XAMBOT-1102'

New commits in xamarin/maccore:

* xamarin/maccore@55a700bb5b [build] Add /restore to Xamarin.Analysis build (dotnet#2366)

Removed commits from xamarin/maccore:

* xamarin/maccore@c42b49fd29 [build] Add /restore to Xamarin.Analysis build

Diff: https://github.com/xamarin/maccore/compare/c42b49fd298377220a53070a2b3a25d3274d7f79..55a700bb5ba3c092f511075d479d82ecb10fa5fe
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ Tests failed on Build ❌

Tests failed on Build.

Test results

1 tests failed, 40 tests passed.

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

Pipeline on Agent XAMBOT-1095'

@pjcollins pjcollins removed the do-not-merge Do not merge this pull request label Jan 18, 2021
@rolfbjarne

Copy link
Copy Markdown
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2154)

@rolfbjarne
rolfbjarne merged commit 3b7373c into dotnet:main Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants