[Xcode12.5] Fix regression test not to crash. fixes #10918 - #10919
Conversation
The api does not longer allow you to pass a null ptr. Create a dummy controller: fixes dotnet#10918
| } | ||
| } | ||
| } No newline at end of file | ||
| } |
There was a problem hiding this comment.
your editor does not like stories files that ends well...
There was a problem hiding this comment.
or you want to make sure you always have the last word char in every file ?
There was a problem hiding this comment.
Wait! Rolf wants the new line! my editor might have made a decision this time that he should't, bad vim!
There was a problem hiding this comment.
Ideally your editor does not change anything you did not touch, including end-of-file.
| Assert.IsNotNull (t.GetMethod ("UpdateSearchResultsForSearchController"), "preserved"); | ||
| using (var controller = new UISplitViewController ()) { | ||
| var sc = new UISearchController ((UIViewController)controller); | ||
| sc.SetSearchResultsUpdater ((vc) => { }); |
There was a problem hiding this comment.
I know this is not introduced here, but what does this syntax mean?
(vc) => { }
There was a problem hiding this comment.
If you look at the method, the first param is a Action<UIKit.UISearchController> updateSearchResults. The test is simply adding a lambda that takes a first param (viewController) and does nothing.
Could be:
Action<UIKit.UISearchController> cb = (vc) => {
// your code goes here
};
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable Test results3 tests failed, 172 tests passed.Failed tests
Pipeline on Agent XAMBOT-1109' |
5 participants
The api does not longer allow you to pass a null ptr. Create a dummy
controller:
fixes #10918