[dotnet] Enable more trimming switches - #11295
Merged
Merged
Conversation
Documentation https://github.com/dotnet/runtime/blob/main/docs/workflow/trimming/feature-switches.md Very small effect on the final app size. Before https://gist.github.com/spouliot/9f6fa4f15c117149905141f80fbad399 After https://gist.github.com/spouliot/c9cefac8aa77c8c68edb9bbc77f553d0
mandel-macaque
approved these changes
Apr 22, 2021
Contributor
Author
|
@dalexsoto yeah I ❤️ sorted keys 😄 but in this case there was a typo too: |
rolfbjarne
approved these changes
Apr 22, 2021
Collaborator
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results2 tests failed, 102 tests passed.Failed tests
|
Contributor
Author
known, likely network related, issue -> https://github.com/xamarin/maccore/issues/2211 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation
https://github.com/dotnet/runtime/blob/main/docs/workflow/trimming/feature-switches.md
Very small effect on the final app size.
Before
https://gist.github.com/spouliot/9f6fa4f15c117149905141f80fbad399
After
https://gist.github.com/spouliot/c9cefac8aa77c8c68edb9bbc77f553d0