Skip to content

[dotnet] Enable more trimming switches - #11295

Merged
spouliot merged 1 commit into
dotnet:mainfrom
spouliot:enable-moar-switches
Apr 23, 2021
Merged

[dotnet] Enable more trimming switches#11295
spouliot merged 1 commit into
dotnet:mainfrom
spouliot:enable-moar-switches

Conversation

@spouliot

Copy link
Copy Markdown
Contributor

@spouliot spouliot added the not-notes-worthy Ignore for release notes label Apr 22, 2021

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sebastien.Sort ✅

@spouliot

Copy link
Copy Markdown
Contributor Author

@dalexsoto yeah I ❤️ sorted keys 😄 but in this case there was a typo too: HttpNativeHandler != UseNativeHttpHandler

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

Test results

2 tests failed, 102 tests passed.

Failed tests

  • link all/iOS Unified 64-bits - simulator/Debug: Failed
  • link all/tvOS - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1109'
Merge 06148b3 into 0924ce5

@spouliot

Copy link
Copy Markdown
Contributor Author
TrustUsingOldPolicy: System.Net.WebException : Error: TrustFailure (Authentication failed, see inner exception.)
----> System.Security.Authentication.AuthenticationException : Authentication failed, see inner exception.
----> NUnit.Framework.AssertionException : Unknown Certificate Problem
Expected: 0
But was: -2146762485
1) Unknown Certificate Problem
Expected: 0
But was: -2146762485

known, likely network related, issue -> https://github.com/xamarin/maccore/issues/2211

@spouliot
spouliot merged commit 095b7e1 into dotnet:main Apr 23, 2021
@spouliot
spouliot deleted the enable-moar-switches branch April 23, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants