[registrar] Make sure to release the return value from xamarin_get_parameter_type. - #11725
Merged
rolfbjarne merged 1 commit intoMay 28, 2021
Conversation
…rameter_type.
Before:
There were 258046 MonoObjects created, 235142 MonoObjects freed, so 22904 were not freed. (dynamic registrar)
There were 205804 MonoObjects created, 204193 MonoObjects freed, so 1611 were not freed. (static registrar)
After:
There were 258054 MonoObjects created, 235172 MonoObjects freed, so 22882 were not freed. (dynamic registrar)
There were 205804 MonoObjects created, 205190 MonoObjects freed, so 614 were not freed. (static registrar)
rolfbjarne
added
not-notes-worthy
spouliot
reviewed
May 28, 2021
| for (int i = 0; i < index + 1; i++) { | ||
| xamarin_mono_object_release (&p); | ||
| p = mono_signature_get_params (msig, &iter); | ||
| } |
Contributor
There was a problem hiding this comment.
that seems duplicated inside #11730
same comments
- first iteration p == NULL, is that fine ?
- last iteration, should not
pbe released ?
Member
Author
There was a problem hiding this comment.
yeah, I repeated myself...
Hopefully there won't be any merge conflicts!
spouliot
approved these changes
May 28, 2021
Collaborator
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 108 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
Member
Author
|
Test failures are unrelated:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: