Skip to content

[Carplay] Add support for Xcode 13 beta 5 and fix catalyst attrs. - #12454

Merged
mandel-macaque merged 2 commits into
dotnet:mainfrom
mandel-macaque:carplay-xcode13-bet5
Aug 17, 2021
Merged

[Carplay] Add support for Xcode 13 beta 5 and fix catalyst attrs.#12454
mandel-macaque merged 2 commits into
dotnet:mainfrom
mandel-macaque:carplay-xcode13-bet5

Conversation

@mandel-macaque

@mandel-macaque mandel-macaque commented Aug 16, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Aug 16, 2021
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Aug 17, 2021

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 101 tests passed.

Failed tests

  • xammac tests/Mac Modern/Release: Failed (Test run failed.
    Tests run: 2469 Passed: 2403 Inconclusive: 10 Failed: 1 Ignored: 65)

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 722490a into 3af0e34

@mandel-macaque

mandel-macaque commented Aug 17, 2021

Copy link
Copy Markdown
Contributor Author

Failure is not related: https://github.com/xamarin/maccore/issues/2493

spouliot
spouliot suggested changes Aug 17, 2021
View reviewed changes
Comment thread src/carplay.cs

[NoWatch, NoTV, NoMac, iOS (15,0), MacCatalyst (15,0)]
[BaseType (typeof(NSObject))]
interface CPAssistantCellConfiguration : NSSecureCoding

@spouliot spouliot Aug 17, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> [DisableDefaultCtor]
there's no way to change the default, empty/null, value if init is used - so it's unusable

mandel-macaque
mandel-macaque commented Aug 17, 2021
View reviewed changes
Comment thread src/carplay.cs
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Aug 17, 2021

Copy link
Copy Markdown
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 102 tests passed 🎉

Pipeline on Agent XAMBOT-1104.BigSur
Merge ab90775 into 08eaaf9

@mandel-macaque
mandel-macaque merged commit 0b01c40 into dotnet:main Aug 17, 2021
@mandel-macaque
mandel-macaque deleted the carplay-xcode13-bet5 branch August 17, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes
@rolfbjarne rolfbjarne rolfbjarne approved these changes
+1 more reviewer
@spouliot spouliot spouliot approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

note-highlight Worth calling out specifically in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mandel-macaque @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @spouliot