[CoreAudio] Updates for Xcode13 Beta 5 by tj-devel709 · Pull Request #12465 · dotnet/macios

tj-devel709 · 2021-08-17T19:59:16Z

There were a few changes in the headers that I believe are not bound by us:

kAudioAggregateDevicePropertyMasterSubDevice -> kAudioAggregateDevicePropertyMainSubDevice
mMasterHostTicksPerFrame -> mMainHostTicksPerFrame | inside AudioServerPlugInIOCycleInfo (confirmed in office hours)
kAudioHardwareNotReadyError
kAudioHardwarePropertyProcessIsMaster -> kAudioHardwarePropertyProcessIsMain
- although it seems as though the AudioObjectPropertySelector holds the values for kAudioHardwareProperty as well?

mandel-macaque · 2021-08-17T20:10:51Z

 		TranslateUIDToBox = 1969841250, // 'uidb'
 		ClockDeviceList = 1668049699, //'clk#'
 		TranslateUidToClockDevice = 1969841251, // 'uidc',
+		[Obsolete ("Use the 'ProcessIsMain' element instead.")]


You are missing the deprecated attrs:

[Deprecated (PlatformName.TvOS, 15,0)]

you will have to add them for each of the supported platforms.

unlike the other enum this one has a different value so it's useful to know when it should be avoided

mandel-macaque · 2021-08-17T20:11:02Z

 		TranslateUidToClockDevice = 1969841251, // 'uidc',
+		[Obsolete ("Use the 'ProcessIsMain' element instead.")]
 		ProcessIsMaster = 1835103092, // 'mast'
+		ProcessIsMain = 1835100526, // 'main'


AFAIK we should say when it was added.

With a comment?

spouliot · 2021-08-17T20:16:53Z

 		ActualSampleRate = 1634955892,// 'asrt',
 		ClockDevice = 1634755428, // 'apcd',
 		IOThreadOSWorkgroup = 1869838183, // 'oswg'
+		ProcessMute = 1634758765, // 'appm'


^ needs availability attributes - for both NET and legacy

if it's not available in tvOS then it needs [NoTV] and [SupportedOSPlatform ("tvos")]
unless the enum type itself is not available ?

otherwise it implies availability for tvOS 9 (for legacy) or tvOS 10 (for net6)

spouliot · 2021-08-17T20:18:18Z

 		TranslateUIDToBox = 1969841250, // 'uidb'
 		ClockDeviceList = 1668049699, //'clk#'
 		TranslateUidToClockDevice = 1969841251, // 'uidc',
+		[Obsolete ("Use the 'ProcessIsMain' element instead.")]


unlike the other enum this one has a different value so it's useful to know when it should be avoided

vs-mobiletools-engineering-service2 · 2021-08-17T23:57:30Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 103 tests passed.

Failed tests

dont link/Mac Catalyst/Debug [dotnet]: Failed (Test run crashed (exit code: 134).
Tests run: 11 Passed: 6 Inconclusive: 0 Failed: 0 Ignored: 5)
xcframework-test/Mac Catalyst/Debug: Failed (Test run crashed (exit code: 134).
Tests run: 2 Passed: 2 Inconclusive: 0 Failed: 0 Ignored: 0)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 76e5722 into 264eaba

vs-mobiletools-engineering-service2 · 2021-08-19T04:20:44Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 6baedc2 into 243cc40

tj-devel709 · 2021-08-19T17:37:56Z

/azp run

azure-pipelines · 2021-08-19T17:38:25Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2021-08-19T18:05:18Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 6baedc2 into 509b099

tj-devel709 · 2021-08-20T14:48:07Z

@spouliot and others
When I checked the apidiff, ProcessIsMaster changed to ProcessIsMain and ProcessMute was added only in the iOS diff and mac diff. These were added in MacCatalyst, and nothing happened in tv and watch.
Therefore I am concluding these are only available in ios, mac, and mac catalyst

vs-mobiletools-engineering-service2 · 2021-08-20T15:09:09Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 7583f57 into 2d4b68b

spouliot · 2021-08-23T13:53:39Z

 		ActualSampleRate = 1634955892,// 'asrt',
 		ClockDevice = 1634755428, // 'apcd',
 		IOThreadOSWorkgroup = 1869838183, // 'oswg'
+		ProcessMute = 1634758765, // 'appm'


if it's not available in tvOS then it needs [NoTV] and [SupportedOSPlatform ("tvos")]
unless the enum type itself is not available ?

otherwise it implies availability for tvOS 9 (for legacy) or tvOS 10 (for net6)

vs-mobiletools-engineering-service2 · 2021-08-24T03:01:43Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 1a79ecd into bbb2118

mandel-macaque · 2021-08-26T02:45:46Z

@tj-devel709 this PR needs updating because it does not compile.

vs-mobiletools-engineering-service2 · 2021-08-26T20:40:25Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 108 tests passed 🎉

Pipeline on Agent XAMBOT-1098.BigSur'
Merge b378ba6 into 58ae71b

TJ Lambert added 2 commits August 17, 2021 11:09

initial changes

1447fba

Adding manual changes

76e5722

tj-devel709 added the note-highlight Worth calling out specifically in release notes label Aug 17, 2021

tj-devel709 added this to the xcode13.0 milestone Aug 17, 2021

tj-devel709 requested review from dalexsoto and spouliot as code owners August 17, 2021 19:59

mandel-macaque suggested changes Aug 17, 2021

View reviewed changes

spouliot suggested changes Aug 17, 2021

View reviewed changes

rolfbjarne approved these changes Aug 18, 2021

View reviewed changes

Manual changes

6baedc2

removing types not available in

7583f57

spouliot suggested changes Aug 23, 2021

View reviewed changes

Sebastien changes

1a79ecd

mandel-macaque added 3 commits August 26, 2021 11:18

Merge branch 'main' into Xcode13-CoreAudio-Beta5

f6aaa35

Fix compilation issues.

6b3b8fb

Merge branch 'main' into Xcode13-CoreAudio-Beta5

b378ba6

spouliot approved these changes Aug 30, 2021

View reviewed changes

mandel-macaque approved these changes Aug 30, 2021

View reviewed changes

mandel-macaque merged commit e3f1363 into dotnet:main Aug 30, 2021

Uh oh!

Conversation

tj-devel709 commented Aug 17, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 17, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 19, 2021

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Uh oh!

tj-devel709 commented Aug 19, 2021

Uh oh!

azure-pipelines Bot commented Aug 19, 2021

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 19, 2021

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Uh oh!

tj-devel709 commented Aug 20, 2021

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 20, 2021

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 24, 2021

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Uh oh!

mandel-macaque commented Aug 26, 2021

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 26, 2021

✅ [PR Build] Tests passed on Build. ✅

API diff

API & Generator diff

GitHub pages

🎉 All 108 tests passed 🎉

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants