Import .NET 6 property page targets path in iOS sdk targets - #12556
Merged
Conversation
japarson
marked this pull request as ready for review
August 26, 2021 08:05
rolfbjarne
approved these changes
Aug 26, 2021
Collaborator
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results34 tests failed, 106 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
spouliot
approved these changes
Aug 26, 2021
chamons
approved these changes
Aug 26, 2021
emaf
approved these changes
Aug 26, 2021
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Contributor
|
/sudo backport release/6.0.1xx-rc.1 |
Collaborator
|
Backport Job to branch release/6.0.1xx-rc.1 Created! The magic is happening here |
Collaborator
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5137888 for more details. |
Collaborator
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results5 tests failed, 135 tests passed.Failed tests
Pipeline on Agent XAMBOT-1097.BigSur' |
Member
|
Test failures are unrelated:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .NET 6 iOS projects will use the dotnet-project system property pages system which requires the authored .xaml pages to be imported as MEF components. I'm hooking into the Microsoft.iOS.Windows.Sdk.targets file to import Xamarin.iOS.DesignTime.targets which will import each .xaml property page as a PropertyPageSchema.
The property pages will be placed in the same directory as the designtime targets file.