[msbuild] Don't rm -rf the .dSYM dir in the _CompileToNative target - #1266
Merged
Conversation
That logic wrongly assumed that mtouch will always output a new native executable file and that the dSYMs will need to be regenerated, but that is not the case. Move the rm -rf logic into the _GenerateDebugSymbols target instead, so that we only delete the dSYMs if we've already committed to regenerating them. Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=41231 For a walk-through of the problem, see https://bugzilla.xamarin.com/show_bug.cgi?id=47803#c9
Contributor
|
Build failure |
Member
Author
|
hudson.plugins.git.GitException: Command "git submodule update --init --recursive" returned status code 143: |
Member
Author
|
build |
Contributor
|
Build success |
spouliot
added
the
requires-approval-before-merge
Contributor
|
@jstedfast I have not seen the trello card for it in https://trello.com/b/FRdVOYky/platform-cycle-8-service-release-2 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That logic wrongly assumed that mtouch will always output a new
native executable file and that the dSYMs will need to be regenerated,
but that is not the case.
Move the rm -rf logic into the _GenerateDebugSymbols target instead,
so that we only delete the dSYMs if we've already committed to
regenerating them.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=41231
For a walk-through of the problem, see
https://bugzilla.xamarin.com/show_bug.cgi?id=47803#c9