[avfoundation] Fix incorrect selector for AVPlayerItemVideoOutput .ctor. Fixes #48382 - #1276
Merged
Conversation
…or. Fixes #48382 Commit ba37aa4 workaround around a signature clash incorrectly and turned the selector to static ones (and incorrectly set the handle) Also fix a typo in the [Advice] attribute of the old API https://bugzilla.xamarin.com/show_bug.cgi?id=48382
Contributor
|
Build success |
rolfbjarne
reviewed
Dec 1, 2016
| } | ||
|
|
||
| AVPlayerItemVideoOutput (NSDictionary data, AVPlayerItemVideoOutput.InitMode mode) : this (IntPtr.Zero) | ||
| AVPlayerItemVideoOutput (NSDictionary data, AVPlayerItemVideoOutput.InitMode mode) : this () |
Member
There was a problem hiding this comment.
Shouldn't this call : base (NSObjectFlag.Empty) instead?
Otherwise we'll be doing this:
[[[AVPlayerItemVideoOutput] alloc] init] initWith..]
i.e. calling init* twice.
Contributor
Author
There was a problem hiding this comment.
agreed, once is enough :)
Contributor
|
Build success |
spouliot
added a commit
that referenced
this pull request
Dec 7, 2016
…or. Fixes #48382 (#1276) Commit ba37aa4 workaround around a signature clash incorrectly and turned the selector to static ones (and incorrectly set the handle) Also fix a typo in the [Advice] attribute of the old API https://bugzilla.xamarin.com/show_bug.cgi?id=48382
spouliot
added a commit
that referenced
this pull request
Dec 7, 2016
…or. Fixes #48382 (#1276) Commit ba37aa4 workaround around a signature clash incorrectly and turned the selector to static ones (and incorrectly set the handle) Also fix a typo in the [Advice] attribute of the old API https://bugzilla.xamarin.com/show_bug.cgi?id=48382
rolfbjarne
pushed a commit
to rolfbjarne/macios
that referenced
this pull request
Dec 8, 2016
…or. Fixes #48382 (dotnet#1276) Commit ba37aa4 workaround around a signature clash incorrectly and turned the selector to static ones (and incorrectly set the handle) Also fix a typo in the [Advice] attribute of the old API https://bugzilla.xamarin.com/show_bug.cgi?id=48382
rolfbjarne
added a commit
that referenced
this pull request
Dec 8, 2016
…or. Fixes #48382 (#1276) (#1321) Commit ba37aa4 workaround around a signature clash incorrectly and turned the selector to static ones (and incorrectly set the handle) Also fix a typo in the [Advice] attribute of the old API https://bugzilla.xamarin.com/show_bug.cgi?id=48382
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit ba37aa4 workaround around a signature clash incorrectly and
turned the selector to static ones (and incorrectly set the handle)
Also fix a typo in the [Advice] attribute of the old API
https://bugzilla.xamarin.com/show_bug.cgi?id=48382