Skip to content

[tools] Keep passing 'direct-icalls' to the AOT compiler for legacy Xamarin. Fixes #12810. - #12812

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:issue-12810
Sep 23, 2021
Merged

[tools] Keep passing 'direct-icalls' to the AOT compiler for legacy Xamarin. Fixes #12810.#12812
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:issue-12810

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Fixes #12810.
Fixes mono/mono#21210.

@rolfbjarne
rolfbjarne requested a review from chamons as a code owner September 23, 2021 05:50
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Sep 23, 2021
@rolfbjarne

Copy link
Copy Markdown
Member Author

/sudo backport xcode13-ios

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

Backport Job to branch xcode13-ios Created! The magic is happening here

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5240981 for more details.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 136 tests passed.

Failed tests

  • introspection/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge ab55edd into 5a0a5cd

@rolfbjarne

Copy link
Copy Markdown
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2414).

@rolfbjarne
rolfbjarne merged commit 4dad2ca into dotnet:main Sep 23, 2021
@rolfbjarne
rolfbjarne deleted the issue-12810 branch September 23, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests

Projects

None yet

3 participants