Skip to content

[Foundation] Remove warning due to the Equals accepting a null value. #12839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mandel-macaque merged 2 commits into from
Sep 28, 2021
Merged

[Foundation] Remove warning due to the Equals accepting a null value. #12839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd8ba69
[Foundation] Remove warning due to the Equals accepting a null value.
mandel-macaque Sep 27, 2021
f2e2c7b
Merge branch 'main' into nshost-warning
mandel-macaque Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/foundation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13775,7 +13775,7 @@ partial interface NSHost {
NSHost _FromAddress (string address);

[Export ("isEqualToHost:")]
bool Equals (NSHost host);
bool Equals ([NullAllowed] NSHost host);

[Export ("name")]
string Name { get; }
Expand Down
22 changes: 22 additions & 0 deletions tests/monotouch-test/Foundation/NSHostTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
#if __MACOS__
using System;
using System.Collections;
using System.Collections.Generic;

using NUnit.Framework;

using Foundation;

#nullable enable

namespace MonoTouchFixtures.Foundation {
public class NSHostTest {

public void EqualsNullAllowed ()
{
using var host = NSHost.FromAddress ("http://microsoft.com");
Assert.False (host.Equals (null));
}
}
}
#endif
3 changes: 3 additions & 0 deletions tests/xtro-sharpie/macOS-Foundation.ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,3 +834,6 @@
!missing-null-allowed! 'System.Void Foundation.NSUserNotification::set_Subtitle(System.String)' is missing an [NullAllowed] on parameter #0
!missing-null-allowed! 'System.Void Foundation.NSUserNotification::set_Title(System.String)' is missing an [NullAllowed] on parameter #0
!missing-null-allowed! 'System.Void Foundation.NSUserNotification::set_UserInfo(Foundation.NSDictionary)' is missing an [NullAllowed] on parameter #0

# added because the method does the right thing yet it was not marked by apple, there is a test for it
!extra-null-allowed! 'System.Boolean Foundation.NSHost::Equals(Foundation.NSHost)' has a extraneous [NullAllowed] on parameter #0