Skip to content

[introspection] Skip verifying the objc_msgSend[Super]_stret on all platforms. #12939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 3 commits into from
Oct 7, 2021
Merged

[introspection] Skip verifying the objc_msgSend[Super]_stret on all platforms. #12939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce11d0c
[introspection] Skip verifying the objc_msgSend[Super]_stret on all p…
rolfbjarne Oct 6, 2021
4bd6a6c
Call the base implementation in MacApiInvokeTest.Skip
rolfbjarne Oct 7, 2021
3ccbdc0
Merge remote-tracking branch 'origin/main' into introspection-skip-ms…
rolfbjarne Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/introspection/ApiPInvokeTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,13 @@ protected virtual bool CheckForEnumParameter (MethodInfo mi, ParameterInfo pi)

protected virtual bool Skip (string symbolName)
{
switch (symbolName) {
// it's not needed for ARM64/ARM64_32 and Apple does not have stubs for them in libobjc.dylib
// also the linker normally removes them (unreachable due to other optimizations)
case "objc_msgSend_stret":
case "objc_msgSendSuper_stret":
return true;
}
return false;
}

Expand Down
2 changes: 1 addition & 1 deletion tests/introspection/Mac/MacApiPInvokeTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ protected override bool Skip (string symbolName)
case "SKTerminateForInvalidReceipt": // Only there for API compat
return !IsUnified;
}
return false;
return base.Skip (symbolName);
}

protected override bool SkipAssembly (Assembly a)
Expand Down
4 changes: 0 additions & 4 deletions tests/introspection/iOS/iOSApiPInvokeTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ protected override bool Skip (string symbolName)
case "CVPixelBufferGetIOSurface":
case "CVPixelBufferCreateWithIOSurface":
return simulator && !TestRuntime.CheckXcodeVersion (11, 0);
// it's not needed for ARM64/ARM64_32 and Apple does not have stubs for them in libobjc.dylib
case "objc_msgSend_stret":
case "objc_msgSendSuper_stret":
return !simulator;

default:
// MLCompute not available in simulator as of Xcode 12 beta 3
Expand Down