[ObjCRuntime] Make BaseWrapper subclass NativeObject + numerous other code updates - #13000
Merged
Merged
Conversation
rolfbjarne
commented
Oct 15, 2021
rolfbjarne
commented
Member
- Subclass NativeObject to reuse object lifetime code.
- Enable nullability and fix code accordingly.
… code updates * Subclass NativeObject to reuse object lifetime code. * Enable nullability and fix code accordingly.
chamons
approved these changes
Oct 15, 2021
Collaborator
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 102 tests passed 🎉Pipeline on Agent XAMBOT-1097.BigSur' |
tj-devel709
approved these changes
Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.