[mtouch] -lsqlite3 is a linker flag, not a file to be linked with, so treat it accordingly. Fixes #49220. - #1313
Merged
Conversation
… treat it accordingly. Fixes #49220. -lsqlite3 is a linker flag, not a file to be linked with, so when automatically determining that we need to pass -lsqlite3 we need to put it in the right list of linker information. Otherwise we may end up passing `-force_load -lsqlite3` to the linker (if the assembly's ForceLoad flag is set), which won't compile. https://bugzilla.xamarin.com/show_bug.cgi?id=49220
Contributor
|
Build failure |
Member
Author
|
Test failure is unrelated (mmp timeout filed as bug #47736). |
Member
Author
|
C9 PR: #1317 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-lsqlite3 is a linker flag, not a file to be linked with, so when
automatically determining that we need to pass -lsqlite3 we need to put it in
the right list of linker information.
Otherwise we may end up passing
-force_load -lsqlite3to the linker (if theassembly's ForceLoad flag is set), which won't compile.
https://bugzilla.xamarin.com/show_bug.cgi?id=49220