[mtouch] Fix BundleId. - #1318
Merged
Merged
Conversation
The BundleId property is used by the code that generates the mSYM directory, but its value was always the default value 'com.yourcompany.sample' instead of looked up in the app's Info.plist. So fix the BundleId property to do the expected. Also fix the mSYM test (SymbolicationData) to actually test mSYM stuff (it was partially disabled when we disabled automatic mSYM generation for C8, and never re-enabled), and port it to the new and better test syntax, and add a few more asserts to check the manifest.xml generation.
Contributor
|
Build failure |
Member
Author
|
Test failure is unrelated (monotouch-test failed to build, which will be fixed with PR #1321). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BundleId property is used by the code that generates the mSYM directory,
but its value was always the default value 'com.yourcompany.sample' instead of
looked up in the app's Info.plist.
So fix the BundleId property to do the expected.
Also fix the mSYM test (SymbolicationData) to actually test mSYM stuff (it was
partially disabled when we disabled automatic mSYM generation for C8, and
never re-enabled), and port it to the new and better test syntax, and add a
few more asserts to check the manifest.xml generation.