Skip to content

[.NET/SystemConfiguration] Use [UnmanagedCallersOnly] instead of [MonoPInvokeCallback] for the managed callbacks called from native code. - #13295

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:dotnet-unmanagedcallers-systemconfiguration
Nov 8, 2021
Merged

[.NET/SystemConfiguration] Use [UnmanagedCallersOnly] instead of [MonoPInvokeCallback] for the managed callbacks called from native code.#13295
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:dotnet-unmanagedcallers-systemconfiguration

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Ref #10470.

…oPInvokeCallback] for the managed callbacks called from native code.

Ref dotnet#10470.
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Nov 5, 2021
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

5 tests failed, 94 tests passed.

Failed tests

  • monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2539 Passed: 2413 Inconclusive: 10 Failed: 1 Ignored: 125)
  • monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Tests run: 2704 Passed: 2500 Inconclusive: 35 Failed: 1 Ignored: 203)
  • xammac tests/Mac Modern/Debug: Failed (Test run failed.
    Tests run: 2544 Passed: 2423 Inconclusive: 10 Failed: 1 Ignored: 120)
  • xammac tests/Mac Modern/Release: Failed (Test run failed.
    Tests run: 2541 Passed: 2419 Inconclusive: 10 Failed: 1 Ignored: 121)
  • xammac tests/Mac Modern/Release (all optimizations): Failed (Test run failed.
    Tests run: 2541 Passed: 2418 Inconclusive: 10 Failed: 1 Ignored: 122)

Pipeline on Agent XAMBOT-1098.BigSur'
Merge 35c8981 into 6b3ebd2

@rolfbjarne

Copy link
Copy Markdown
Member Author

Test failures are unrelated (https://github.com/xamarin/maccore/issues/2525).

Build is currently broken in main, waiting to merge until that's fixed (#13304).

@rolfbjarne
rolfbjarne merged commit d456d5f into dotnet:main Nov 8, 2021
@rolfbjarne
rolfbjarne deleted the dotnet-unmanagedcallers-systemconfiguration branch November 8, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants