Skip to content

[tests] Add missing test file for backport in c4710f69. - #1332

Merged
spouliot merged 1 commit into
dotnet:cycle8-xifrom
rolfbjarne:cycle8-xi-missing-test-file
Dec 12, 2016
Merged

[tests] Add missing test file for backport in c4710f69.#1332
spouliot merged 1 commit into
dotnet:cycle8-xifrom
rolfbjarne:cycle8-xi-missing-test-file

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

No description provided.

@rolfbjarne rolfbjarne added the requires-approval-before-merge The pull request requires special approval before it can be merged label Dec 12, 2016
@rolfbjarne

Copy link
Copy Markdown
Member Author

@spouliot monotouch-test fails to build with (see PR #1330) on the cycle8-xi branch:

CSC: error CS2001: Source file `AVFoundation/PlayerItemVideoOutputTest.cs' could not be found

it looks like c4710f6 should have included that file.

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@rolfbjarne

Copy link
Copy Markdown
Member Author

Test failures are unrelated (bug #46097 occurred twice, for introspection-ios/watchOS and dontlink/watchOS), so this is green from Jenkins.

@spouliot

Copy link
Copy Markdown
Contributor

thanks!

@spouliot
spouliot merged commit bffcc0a into dotnet:cycle8-xi Dec 12, 2016
mandel-macaque added a commit to mandel-macaque/xamarin-macios that referenced this pull request Feb 12, 2019
The bots sometimes have issues with the network. We do not want red
builds due to a problem in the connection. Lets set the test to
inclonclusive since we cannot assert the headers that have been sent.

Fixes https://github.com/xamarin/maccore/issues/1332
mandel-macaque added a commit that referenced this pull request Feb 12, 2019
The bots sometimes have issues with the network. We do not want red
builds due to a problem in the connection. Lets set the test to
inclonclusive since we cannot assert the headers that have been sent.

Fixes https://github.com/xamarin/maccore/issues/1332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-approval-before-merge The pull request requires special approval before it can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants