Msbuild delay codesign - #1350
Merged
Merged
Conversation
Instead of codesigning App Extensions as part of the App Extension build, we now codesign them as part of the Codesign target of the main app project.
By using an ItemGroup, we save all of the metadata even if the values are null/empty. Using CreateItem, any metadata property with a null or empty value was not being saved in the .items file.
...instead of having to use %(_AppExtensionCodesignProperties.Filename)%(_AppExtensionCodesignProperties.Extension)
Member
Author
|
Feel free to review, but probably isn't worth merging until the |
Contributor
|
Build failure |
jstedfast
added a commit
that referenced
this pull request
Dec 15, 2016
This is a fixup to the PR in issue #1350. We really only want to delay codesigning of the App Extension *bundle*, but want to codesign any native libs and frameworks as usual.
rolfbjarne
pushed a commit
that referenced
this pull request
Dec 16, 2016
This is a fixup to the PR in issue #1350. We really only want to delay codesigning of the App Extension *bundle*, but want to codesign any native libs and frameworks as usual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.