[mobilecoreservices] Modernize UTType by spouliot · Pull Request #13831 · dotnet/macios

spouliot · 2022-01-21T15:27:13Z

Use is instead of == for null checks
Use ThrowHelper to throw common exceptions
Use faster CFString API (over the slower NSString variants)

* Use `is` instead of `==` for null checks * Use `ThrowHelper` to throw common exceptions * Use faster `CFString` API (over the slower `NSString` variants)

chamons · 2022-01-21T15:37:39Z

/azp run

azure-pipelines · 2022-01-21T15:38:01Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2022-01-21T22:14:06Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

Generator diff

ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 105 tests passed.

Failed tests

monotouch-test/Mac [dotnet]/Debug [dotnet]: BuildFailure
monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure
dont link/Mac Catalyst [dotnet]/Release [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 6432296 into b0a6131

chamons · 2022-01-24T14:48:19Z

/azp run

chamons · 2022-01-24T14:48:37Z

Test failure was "App Build monotouch-test Debug [dotnet]", which I had not seen before.

azure-pipelines · 2022-01-24T14:48:38Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2022-01-24T19:01:01Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

Generator diff

✅ Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 106 tests passed.

Failed tests

monotouch-test/Mac [dotnet]/Debug [dotnet]: BuildFailure
monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure

Pipeline on Agent XAMBOT-1097.BigSur'
Merge 6432296 into 67a6e82

spouliot · 2022-01-24T20:50:38Z

@chamons they are build failures so I must have missed some tests 👀

chamons · 2022-01-24T21:35:16Z

/azp run

azure-pipelines · 2022-01-24T21:35:38Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2022-01-25T01:51:53Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

Generator diff

✅ Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 107 tests passed.

Failed tests

monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 2767 Passed: 2570 Inconclusive: 11 Failed: 2 Ignored: 195)

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 3bedf72 into 4fe9874

mandel-macaque · 2022-01-25T02:56:40Z

Known flaky test: https://github.com/xamarin/maccore/issues/2443

[mobilecoreservices] Modernize UTType

6432296

* Use `is` instead of `==` for null checks * Use `ThrowHelper` to throw common exceptions * Use faster `CFString` API (over the slower `NSString` variants)

chamons requested review from mandel-macaque and rolfbjarne January 21, 2022 15:37

rolfbjarne approved these changes Jan 21, 2022

View reviewed changes

tj-devel709 approved these changes Jan 21, 2022

View reviewed changes

chamons added community Community contribution ❤ not-notes-worthy Ignore for release notes labels Jan 24, 2022

[tests] Adjust UTTypeTest.cs to build for net profile

3bedf72

mandel-macaque approved these changes Jan 25, 2022

View reviewed changes

mandel-macaque merged commit eb3015b into dotnet:main Jan 25, 2022

Uh oh!

Conversation

spouliot commented Jan 21, 2022

Uh oh!

chamons commented Jan 21, 2022

Uh oh!

azure-pipelines Bot commented Jan 21, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 21, 2022

❌ [PR Build] Tests failed on Build ❌

API diff

API Current PR diff

Generator diff

GitHub pages

Test results

Failed tests

Uh oh!

chamons commented Jan 24, 2022

Uh oh!

chamons commented Jan 24, 2022

Uh oh!

azure-pipelines Bot commented Jan 24, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 24, 2022

❌ [PR Build] Tests failed on Build ❌

API diff

API Current PR diff

Generator diff

GitHub pages

Test results

Failed tests

Uh oh!

spouliot commented Jan 24, 2022

Uh oh!

chamons commented Jan 24, 2022

Uh oh!

azure-pipelines Bot commented Jan 24, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 25, 2022

❌ [PR Build] Tests failed on Build ❌

API diff

API Current PR diff

Generator diff

GitHub pages

Test results

Failed tests

Uh oh!

mandel-macaque commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants