[NET Attribute Conversion] Rerun with fixes to catch old/unlisted availability by chamons · Pull Request #14128 · dotnet/macios

chamons · 2022-02-11T16:28:46Z

Turn on one of two tests from [tests] Add disabled NET6 availability attribute test #14106
The other one, and the currently disabled bits will be enabled in a future PR that corrects the generator.

This re-run of of mellite was powered by two changes:

chamons/mellite@650f584 which introduced add-default-introduced that will detect when an API is available on a given platform without availability attributes and create a default "non-versioned" one.
A hack of XM and XI dll which was built with https://github.com/xamarin/xamarin-macios/blob/main/src/generator.cs#L3368 set to never filter any attributes. This way, attributes that existed but were "too old" were there for mel to read.

After that, I could re-run it against all of xamarin-macios (repeating the annoying one time work), and then fixup the test to work.

…ilability

chamons · 2022-02-11T22:57:41Z

Further work on the generator suggests this PR may be incomplete (due to attributes not being seen).

Going to verify before closing or adding to this.

vs-mobiletools-engineering-service2 · 2022-02-11T23:10:45Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

Generator diff

✅ Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 146 tests passed.

Failed tests

introspection/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 37 Passed: 34 Inconclusive: 0 Failed: 1 Ignored: 2)
introspection/iOS Unified 64-bits - simulator/Debug [dotnet]: Failed

Pipeline on Agent XAMBOT-1096.BigSur'
Merge d2ab11e into 39d52ba

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

vs-mobiletools-engineering-service2 · 2022-02-15T00:12:23Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

Generator diff

✅ Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 145 tests passed.

Failed tests

introspection/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 37 Passed: 34 Inconclusive: 0 Failed: 1 Ignored: 2)
introspection/iOS Unified 64-bits - simulator/Debug [dotnet]: Failed
link sdk/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1097.BigSur'
Merge 0705887 into 764e797

…ection

chamons · 2022-02-16T18:51:06Z

Re-ran converter with new missing attribute logic to detect tv/catalyst attributes and use "what exists in the assembly" not "What namespace are you in".

It's even larger, but should only be supported/unsupported attributes.

I'm going to test this with the generator changes in flight and see if it checks out finally...

vs-mobiletools-engineering-service2 · 2022-02-17T01:48:53Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff

iOS vsdrops gist
macOS vsdrops gist
tvOS vsdrops gist
watchOS vsdrops gist

View dotnet API diff

dotnet-iOS vsdrops gist
dotnet-macOS vsdrops gist
dotnet-tvOS vsdrops gist
dotnet-MacCatalyst vsdrops gist

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops gist
dotnet-legacy-macOS vsdrops gist
dotnet-legacy-tvOS vsdrops gist

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops gist

Generator diff

ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

6 tests failed, 140 tests passed.

Failed tests

introspection/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 37 Passed: 34 Inconclusive: 0 Failed: 1 Ignored: 2)
introspection/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 44 Passed: 41 Inconclusive: 0 Failed: 1 Ignored: 2)
introspection/iOS Unified 64-bits - simulator/Debug [dotnet]: Failed
introspection/tvOS - simulator/Debug [dotnet]: Failed
monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 2708 Passed: 2513 Inconclusive: 11 Failed: 3 Ignored: 192)
link sdk/iOS Unified 64-bits - simulator/Debug: Failed

Pipeline on Agent XAMBOT-1100.BigSur'
Merge ddab47f into 404b6e9

rolfbjarne · 2022-02-17T07:31:14Z

 		}

-#if !NET
+#if NET


This is re-introducing a member to .NET that we don't want (the #if !NET surrounded the entire property before the change, but after the change only the availability attributes).

Good catch.

mandel-macaque

The issue I see is as follows, we have obsoleted APIs in iOS exposed in MacCa1talyst that are missing the MacCatalyst Obsoleted OR they show Obsoleted with the iOS version (since there is no #if MACCATALYST we default to the iOS message AFAIK.

mandel-macaque · 2022-02-17T16:13:27Z

 #if NET
 		[SupportedOSPlatform ("maccatalyst14.0")]
+		[SupportedOSPlatform ("ios")]
+		[SupportedOSPlatform ("macos")]


This has an obsolete on iOS, should it have one in maccatalyst?

mandel-macaque · 2022-02-17T16:14:42Z

 #if NET
 		[SupportedOSPlatform ("maccatalyst14.0")]
+		[SupportedOSPlatform ("ios")]
+		[SupportedOSPlatform ("macos")]


mandel-macaque · 2022-02-17T16:15:08Z

 #if NET
 		[SupportedOSPlatform ("ios8.0")]
+		[SupportedOSPlatform ("maccatalyst")]
+		[SupportedOSPlatform ("tvos")]


mandel-macaque · 2022-02-17T16:17:09Z

 		[SupportedOSPlatform ("macos11.0")]
+		[SupportedOSPlatform ("ios")]
+		[SupportedOSPlatform ("maccatalyst")]
+		[SupportedOSPlatform ("tvos")]


mandel-macaque · 2022-02-17T16:17:25Z

+		[SupportedOSPlatform ("tvos")]
 		[UnsupportedOSPlatform ("ios6.0")]
 #if IOS
 		[Obsolete ("Starting with ios6.0 use 'AVAudioSession.Notification.ObserveAudioRouteChange' instead.", DiagnosticId = "BI1234", UrlFormat = "https://github.com/xamarin/xamarin-macios/wiki/Obsolete")]


mandel-macaque · 2022-02-17T16:17:38Z

 		[SupportedOSPlatform ("macos11.0")]
+		[SupportedOSPlatform ("ios")]
+		[SupportedOSPlatform ("maccatalyst")]
+		[SupportedOSPlatform ("tvos")]


mandel-macaque · 2022-02-17T16:17:45Z

 		[SupportedOSPlatform ("macos11.0")]
+		[SupportedOSPlatform ("ios")]
+		[SupportedOSPlatform ("maccatalyst")]
+		[SupportedOSPlatform ("tvos")]


Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

chamons · 2022-02-17T16:40:23Z

@mandel-macaque - I filed #14178 to look at those deprecated outside of this PR.

chamons · 2022-02-17T18:10:23Z

I was able to run Cecil.Tests.AttributeTest.ChildElementsListAvailabilityForAllPlatformsOnParent with this diff and a few test changes, which suggests the API changes are good.

dalexsoto

Could not find anything else, great stuff 👍

vs-mobiletools-engineering-service2 · 2022-02-18T02:00:39Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops
macOS vsdrops
tvOS vsdrops
watchOS vsdrops

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

API Current PR diff

View API diff

iOS vsdrops
macOS vsdrops
tvOS vsdrops
watchOS vsdrops

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

⚠️ Generator diff comments have not been provided.

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

9 tests failed, 137 tests passed.

Failed tests

introspection/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 37 Passed: 34 Inconclusive: 0 Failed: 1 Ignored: 2)
introspection/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 44 Passed: 41 Inconclusive: 0 Failed: 1 Ignored: 2)
introspection/iOS Unified 64-bits - simulator/Debug [dotnet]: Failed
introspection/tvOS - simulator/Debug [dotnet]: Failed
monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: Failed
monotouch-test/watchOS 32-bits - simulator/Debug: TimedOut
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Crashed
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Crashed
monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Crashed

Pipeline on Agent XAMBOT-1106.BigSur'
Merge 61a60e9 into 1273190

vs-mobiletools-engineering-service2 · 2022-02-18T05:26:04Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops
macOS vsdrops
tvOS vsdrops
watchOS vsdrops

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

API Current PR diff

View API diff

iOS vsdrops
macOS vsdrops
tvOS vsdrops
watchOS vsdrops

View dotnet API diff

dotnet-iOS vsdrops
dotnet-macOS vsdrops
dotnet-tvOS vsdrops
dotnet-MacCatalyst vsdrops

View dotnet legacy API diff

dotnet-legacy-iOS vsdrops
dotnet-legacy-macOS vsdrops
dotnet-legacy-tvOS vsdrops

View dotnet iOS-MacCatalayst API diff

dotnet-macCatiOS vsdrops

⚠️ Generator diff comments have not been provided.

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

72 tests failed, 74 tests passed.

Failed tests

introspection/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 37 Passed: 34 Inconclusive: 0 Failed: 1 Ignored: 2)
introspection/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 44 Passed: 41 Inconclusive: 0 Failed: 1 Ignored: 2)
introspection/iOS Unified 64-bits - simulator/Debug [dotnet]: Failed
introspection/iOS Unified 64-bits - simulator/Debug: TimedOut
introspection/tvOS - simulator/Debug [dotnet]: Failed
introspection/tvOS - simulator/Debug: TimedOut
introspection/watchOS 32-bits - simulator/Debug: Crashed
monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Crashed (No test log file was produced)
monotouch-test/iOS Unified 64-bits - simulator/Debug [dotnet]: TimedOut
monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar) [dotnet]: TimedOut
monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): TimedOut
monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): TimedOut
monotouch-test/tvOS - simulator/Debug [dotnet]: TimedOut
monotouch-test/tvOS - simulator/Debug (static registrar) [dotnet]: TimedOut
monotouch-test/tvOS - simulator/Debug (LinkSdk): TimedOut
monotouch-test/tvOS - simulator/Release (all optimizations): TimedOut
monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Crashed
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Crashed
monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Crashed
dont link/Mac [dotnet]/Debug [dotnet]: TimedOut
dont link/Mac [dotnet]/Release [dotnet]: TimedOut
dont link/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut
dont link/Mac Catalyst [dotnet]/Release [dotnet]: TimedOut
dont link/iOS Unified 64-bits - simulator/Release [dotnet]: TimedOut
dont link/iOS Unified 64-bits - simulator/Release: TimedOut
dont link/tvOS - simulator/Release [dotnet]: TimedOut
dont link/tvOS - simulator/Release: TimedOut
dont link/watchOS 32-bits - simulator/Debug: Crashed
dont link/watchOS 32-bits - simulator/Release: Crashed
trimmode copy/Mac [dotnet]/Debug [dotnet]: TimedOut
trimmode copy/Mac [dotnet]/Release [dotnet]: TimedOut
trimmode copy/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut
trimmode copy/Mac Catalyst [dotnet]/Release [dotnet]: TimedOut
trimmode copy/iOS Unified 64-bits - simulator/Release [dotnet]: TimedOut
trimmode copy/tvOS - simulator/Release [dotnet]: TimedOut
fsharp/Mac [dotnet]/Debug [dotnet]: TimedOut
fsharp/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut
fsharp/iOS Unified 64-bits - simulator/Debug: TimedOut
fsharp/tvOS - simulator/Debug: TimedOut
fsharp/watchOS 32-bits - simulator/Debug: Crashed
framework-test/Mac [dotnet]/Debug [dotnet]: TimedOut
framework-test/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut
framework-test/iOS Unified 64-bits - simulator/Debug [dotnet]: TimedOut
framework-test/tvOS - simulator/Debug [dotnet]: TimedOut
framework-test/watchOS 32-bits - simulator/Debug: Crashed
link sdk/iOS Unified 64-bits - simulator/Release [dotnet]: TimedOut
link sdk/iOS Unified 64-bits - simulator/Release: TimedOut
link sdk/tvOS - simulator/Release [dotnet]: TimedOut
link sdk/tvOS - simulator/Release: TimedOut
link sdk/watchOS 32-bits - simulator/Debug: Crashed
link sdk/watchOS 32-bits - simulator/Release: Crashed
link all/iOS Unified 64-bits - simulator/Release [dotnet]: TimedOut
link all/iOS Unified 64-bits - simulator/Release: TimedOut
link all/tvOS - simulator/Release [dotnet]: TimedOut
link all/tvOS - simulator/Release: TimedOut
link all/watchOS 32-bits - simulator/Debug: Crashed
link all/watchOS 32-bits - simulator/Release: Crashed
trimmode link/iOS Unified 64-bits - simulator/Release [dotnet]: TimedOut
trimmode link/tvOS - simulator/Release [dotnet]: TimedOut
xcframework-test/iOS Unified 64-bits - simulator/Debug [dotnet]: TimedOut
xcframework-test/iOS Unified 64-bits - simulator/Debug: TimedOut
xcframework-test/tvOS - simulator/Debug [dotnet]: TimedOut
xcframework-test/tvOS - simulator/Debug: TimedOut
xcframework-test/watchOS 32-bits - simulator/Debug: Crashed
mono-native-compat/iOS Unified Today Extension 64-bits - simulator/Debug: TimedOut
mono-native-compat/watchOS 32-bits - simulator/Debug: Crashed
mono-native-unified/iOS Unified Today Extension 64-bits - simulator/Debug: TimedOut
mono-native-unified/tvOS - simulator/Debug: TimedOut
mono-native-unified/watchOS 32-bits - simulator/Debug: Crashed
interdependent-binding-projects/watchOS 32-bits - simulator/Debug: Crashed
DotNet tests: Failed (Execution failed with exit code 1)

Pipeline on Agent XAMBOT-1109.BigSur'
Merge 61a60e9 into 1273190

chamons · 2022-02-18T15:40:11Z

Looking into test failures now that it's passing and the one test last night.

chamons · 2022-02-18T20:01:01Z

In addition to failure, do-not-merge since I figured out that I get to re-run the converter again due to:

namespace VideoToolbox {
    [iOS (8,0)]
    [TV (10,2)]
    public partial class VTCompressionSession {
    }
}

Not getting conversion on the type itself.

chamons · 2022-03-01T20:40:30Z

This required a lot of work to fix and improve on, so I'm closing and opening a new PR.

chamons added 4 commits February 11, 2022 10:03

[NET Attribute Conversion] Rerun with fixes to catch old/unlisted ava…

cb14b90

…ilability

[NET Attribute Conversion] Chip Framework

0a9e499

Test changes

28c2609

Clean up a diff

d2ab11e

chamons added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Feb 11, 2022

chamons requested review from dalexsoto, mandel-macaque, rolfbjarne, stephen-hawley and tj-devel709 February 11, 2022 16:28

chamons added the do-not-merge Do not merge this pull request label Feb 11, 2022

rolfbjarne approved these changes Feb 14, 2022

View reviewed changes

Comment thread tests/cecil-tests/AttributeTest.cs Outdated

Comment thread tests/cecil-tests/AttributeTest.cs Outdated

Comment thread tests/cecil-tests/AttributeTest.cs Outdated

Comment thread tests/cecil-tests/AttributeTest.cs Outdated

Comment thread tests/cecil-tests/AttributeTest.cs Outdated

tj-devel709 approved these changes Feb 14, 2022

View reviewed changes

dalexsoto approved these changes Feb 14, 2022

View reviewed changes

Apply suggestions from code review

0705887

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Re-run generator again, this time with improved misisng attribute det…

f759043

…ection

chamons removed the do-not-merge Do not merge this pull request label Feb 16, 2022

chamons requested review from dalexsoto, rolfbjarne and tj-devel709 February 16, 2022 18:49

Merge branch 'main' into attribute_super_convert

ddab47f

rolfbjarne requested changes Feb 17, 2022

View reviewed changes

Fix unneeded diff in UIAccessibility

46e0af2

mandel-macaque suggested changes Feb 17, 2022

View reviewed changes

Update tests/cecil-tests/AttributeTest.cs

61a60e9

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

dalexsoto approved these changes Feb 17, 2022

View reviewed changes

rolfbjarne approved these changes Feb 18, 2022

View reviewed changes

chamons added the do-not-merge Do not merge this pull request label Feb 18, 2022

chamons closed this Mar 1, 2022

Uh oh!

Conversation

chamons commented Feb 11, 2022

Uh oh!

chamons commented Feb 11, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 11, 2022

❌ [PR Build] Tests failed on Build ❌

API diff

API Current PR diff

Generator diff

GitHub pages

Test results

Failed tests

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 15, 2022

❌ [PR Build] Tests failed on Build ❌

API diff

API Current PR diff

Generator diff

GitHub pages

Test results

Failed tests

Uh oh!

chamons commented Feb 16, 2022

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 17, 2022

❌ [PR Build] Tests failed on Build ❌

API diff

API Current PR diff

Generator diff

GitHub pages

Test results

Failed tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mandel-macaque left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chamons commented Feb 17, 2022

Uh oh!

chamons commented Feb 17, 2022

Uh oh!

dalexsoto left a comment

Choose a reason for hiding this comment

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 18, 2022

❌ [PR Build] Tests failed on Build ❌

API diff

API Current PR diff

GitHub pages

Test results

Failed tests

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 18, 2022

❌ [PR Build] Tests failed on Build ❌

API diff

API Current PR diff