[linker] Update mscorlib.xml to preserve generic collection interfaces. Fixes #50290 (#1384) - #1427
Merged
Merged
Conversation
…s. Fixes #50290 (dotnet#1384) The `generic_icollection_class` condition (in class.c) does not match the mscorlib.xml descriptor file. + IEnumerator`1 + IReadOnlyList`1 + IReadOnlyCollection`1 reference: https://bugzilla.xamarin.com/show_bug.cgi?id=50290
rolfbjarne
approved these changes
Jan 3, 2017
Contributor
|
Build failure |
Contributor
Author
|
mml-test failed -> https://bugzilla.xamarin.com/show_bug.cgi?id=51197 |
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Feb 11, 2019
Commit list for xamarin/maccore: * xamarin/maccore@584c5d496b Bump maciostools. (dotnet#1427) Diff: xamarin/maccore@49a7f01...584c5d4
chamons
pushed a commit
that referenced
this pull request
Feb 12, 2019
Commit list for xamarin/maccore: * xamarin/maccore@584c5d496b Bump maciostools. (#1427) Diff: https://github.com/xamarin/maccore/compare/49a7f01ced17598cda76200db25a318712311aa0...584c5d496ba1337bb2f16bbd2568d4c5941e09d7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
generic_icollection_classcondition (in class.c) does not match the mscorlib.xml descriptor file.reference:
https://bugzilla.xamarin.com/show_bug.cgi?id=50290