Skip to content

[eventkitui] Add nullability to (generated and manual) bindings - #14423

Merged
tj-devel709 merged 4 commits into
dotnet:mainfrom
tj-devel709:Nullable-EventKitUI
Mar 24, 2022
Merged

[eventkitui] Add nullability to (generated and manual) bindings#14423
tj-devel709 merged 4 commits into
dotnet:mainfrom
tj-devel709:Nullable-EventKitUI

Conversation

@tj-devel709

Copy link
Copy Markdown
Member

This PR aims to bring nullability changes to EventKitUI.
Following the steps here:

  1. I am adding nullable enable to all manual files that are not "API_SOURCES" in src/frameworks.sources and making the required nullability changes

@tj-devel709 tj-devel709 added the not-notes-worthy Ignore for release notes label Mar 15, 2022
@tj-devel709 tj-devel709 added this to the Future milestone Mar 15, 2022
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ Tests failed on macOS Mac Catalina (10.15) ❌

Tests failed on Mac Catalina (10.15).

Failed tests are:

  • xammac_tests
  • monotouch-test

Pipeline on Agent
Merge e6120ce into 792bd80

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌

Tests failed on VSTS: simulator tests iOS.

Test results

1 tests failed, 104 tests passed.

Failed tests

  • MSBuild tests/Integration: Failed (Execution failed with exit code 4)

Pipeline on Agent XAMBOT-1035.Monterey'
Merge e6120ce into 792bd80

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🔥 Tests failed catastrophically on VSTS: simulator tests iOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-simulator\TestSummary.md not found.

Pipeline on Agent
Merge c835b06 into 4fadad7

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ Tests failed on macOS Mac Catalina (10.15) ❌

Tests failed on Mac Catalina (10.15).

Failed tests are:

  • xammac_tests
  • monotouch-test

Pipeline on Agent
Merge c835b06 into 4fadad7

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ Tests failed on macOS Mac Catalina (10.15) ❌

Tests failed on Mac Catalina (10.15).

Failed tests are:

  • xammac_tests
  • monotouch-test

Pipeline on Agent
Merge 3817a84 into 18fa252

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

🎉 All 105 tests passed 🎉

Pipeline on Agent XAMBOT-1044.Monterey'
Merge 3817a84 into 18fa252

@tj-devel709
tj-devel709 merged commit 87a3999 into dotnet:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants