[Xtro] Fix xtro runs for classic when performed in a bot that did not build - #14504
[Xtro] Fix xtro runs for classic when performed in a bot that did not build#14504mandel-macaque wants to merge 9 commits into
Conversation
chamons
left a comment
chamons
left a comment
There was a problem hiding this comment.
Seems reasonable. Want @rolfbjarne 's 👍
|
|
||
| wrench: | ||
| $(MAKE) -j8 classify | ||
| $(MAKE) -j8 classify V=1 |
There was a problem hiding this comment.
Do we still want this bit?
There was a problem hiding this comment.
I want it to see what is going on, might be too verbose locally
rolfbjarne
left a comment
rolfbjarne
left a comment
There was a problem hiding this comment.
I've updated with the tip of main, because 1e8e4bb might have fixed the hangs.
|
|
||
| ifdef TESTS_USE_SYSTEM | ||
| XIOS ?= /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/64bits/iOS/Xamarin.iOS.dll | ||
| XIOS ?= /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/64bits/Xamarin.iOS.dll |
There was a problem hiding this comment.
This is not correct, this file does not exist on my system:
$ ls -la /Library/Frameworks/Xamarin.iOS.framework/Versions/Current/lib/64bits
total 0
drwxr-xr-x 5 rolf staff 160 Jan 17 03:18 .
drwxr-xr-x 9 rolf staff 288 Jan 17 03:20 ..
drwxr-xr-x 4 rolf staff 128 Mar 28 09:18 iOS
drwxr-xr-x 4 rolf staff 128 Mar 28 09:18 tvOS
drwxr-xr-x 4 rolf staff 128 Mar 28 09:18 watchOS| STAMP_CLASSIFY_IOS_DEPS := bin/Debug/xtro-sharpie.exe $(XIOS_PCH) | ||
| ifndef TESTS_USE_SYSTEM | ||
| STAMP_CLASSIFY_IOS_DEPS += $(XIOS) | ||
| STAMP_CLASSIFY_IOS_DEPS += $(XIOS_GL) | ||
| endif |
There was a problem hiding this comment.
The reason you had to do this change was because the dll doesn't exist... but that doesn't make things work, it just makes xtro not run correctly.
rolfbjarne
added
skip-all-tests
|
xtro (legacy) succeeded on the last completed main build: ee302b1#commitcomment-69857175, so this doesn't seem necessary anymore. |
5 participants
Two small fixes: