Skip to content

[NET Attribute Conversion] Add missing attributes in code-behind by re-running conversion - #14660

Merged
chamons merged 4 commits into
dotnet:mainfrom
chamons:reconvert_attributes_final
Apr 7, 2022
Merged

[NET Attribute Conversion] Add missing attributes in code-behind by re-running conversion#14660
chamons merged 4 commits into
dotnet:mainfrom
chamons:reconvert_attributes_final

Conversation

@chamons

@chamons chamons commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

Third times the charm for #14287 right?! This PR is that work, rebased on latest main, with the removal of a few now-unnecessary diffs. It should be only removals from that diff.

Commit by commit review might be helpful, to see a handful of test and generator changes I made outside the mass of attribute changes.

To quote past me:

A few mel commits of note include:

Buckle up, this PR is large (again!).

@chamons chamons added the not-notes-worthy Ignore for release notes label Apr 5, 2022
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ Tests on macOS Mac Catalina (10.15) passed ✅

Tests passed

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Merge 2535583 into 9b605f7

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

❌ Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • xammac_tests
  • monotouch-test

Pipeline on Agent
Merge 2535583 into 9b605f7

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

🎉 All 150 tests passed 🎉

Pipeline on Agent XAMBOT-1097.Monterey
Merge 2535583 into 9b605f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants