[opengles] Update to iOS 10.3 beta 1 - #1576
Conversation
|
Build failure |
| return _PresentRenderbufferAfterMinimumDuration (target, presentationTime); | ||
| break; | ||
| default: | ||
| throw new ArgumentException ("The 'PresentationMode mode' argument needs a value."); |
There was a problem hiding this comment.
I think something like this would be more exact and helpful:
throw new ArgumentOutOfRangeException ($"Unknown presentation mode: {mode}", nameof (mode));
| { | ||
| var obj = new EAGLContext (EAGLRenderingAPI.OpenGLES2); | ||
|
|
||
| Asserts.AreEqual (true, obj.PresentRenderBuffer ((int)RenderbufferTarget.Renderbuffer, 0), "PresentRenderBuffer"); |
There was a problem hiding this comment.
Would it make sense to add an overload that takes a RenderbufferTarget as the target instead of nuint (so that you don't have to cast)? Or are there many possible enums?
There was a problem hiding this comment.
@rolfbjarne I see that there are other enums being used:
OpenTK.Graphics.ES11.All.RenderbufferOes
OpenTK.Graphics.ES20.All.Renderbuffer
OpenTK.Graphics.ES20.RenderbufferTarget.Renderbuffer
OpenTK.Graphics.ES30.All.Renderbuffer
OpenTK.Graphics.ES30.RenderbufferTarget.Renderbuffer
All of the same value: 36161
There was a problem hiding this comment.
OK, that would become messy if we added overloads for every one of those, so I guess typing it as nuint is good enough.
|
|
||
| [iOS (10,0)] | ||
| [TV (10,0)] | ||
| public bool PresentRenderBuffer (nuint target, double presentationTime) |
There was a problem hiding this comment.
check api-diff - in most case what we move from generated to manual bindings needs to be virtual (and removing virtual is a breaking change)
| switch (mode) { | ||
| case PresentationMode.AtTime: | ||
| return _PresentRenderbufferAtTime (target, presentationTime); | ||
| break; |
There was a problem hiding this comment.
no need for break after a return statement. IIRC the C# compiler should be warning you about this...
| break; | ||
| case PresentationMode.AfterMinimumDuration: | ||
| return _PresentRenderbufferAfterMinimumDuration (target, presentationTime); | ||
| break; |
|
Build failure |
|
Unrelated tests failures (due to the move to Xcode8.3) |
6 participants
No description provided.