Skip to content

[release/7.0.1xx-xcode14-rc2] [msbuild] Add a public 'CompileImageAssetsDependsOn' property. Fixes #16065. - #16111

Merged
rolfbjarne merged 1 commit into
dotnet:release/7.0.1xx-xcode14-rc2from
vs-mobiletools-engineering-service2:backport-pr-16089-to-release/7.0.1xx-xcode14-rc2
Sep 23, 2022
Merged

[release/7.0.1xx-xcode14-rc2] [msbuild] Add a public 'CompileImageAssetsDependsOn' property. Fixes #16065.#16111
rolfbjarne merged 1 commit into
dotnet:release/7.0.1xx-xcode14-rc2from
vs-mobiletools-engineering-service2:backport-pr-16089-to-release/7.0.1xx-xcode14-rc2

Conversation

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

Add a public 'CompileImageAssetsDependsOn' property, so that MAUI can inject tasks that
must be completed before we compile image assets:

<PropertyGroup>
	<CompileImageAssetsDependsOn>
		$(CompileImageAssetsDependsOn);
		ResizetizeCollectItems;
	</CompileImageAssetsDependsOn>
</PropertyGroup>

Fixes #16065.

Backport of #16089

…otnet#16065.

Add a public 'CompileImageAssetsDependsOn' property, so that MAUI can inject tasks that
must be completed before we compile image assets:

```xml
<PropertyGroup>
	<CompileImageAssetsDependsOn>
		$(CompileImageAssetsDependsOn);
		ResizetizeCollectItems;
	</CompileImageAssetsDependsOn>
</PropertyGroup>
```

Fixes dotnet#16065.
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator Author

❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌

No test package could be found for tests on macOS Mac Catalina (10.15)

Pipeline on Agent
Hash: ed3bf1276ee83e2e348be888bade364b5a4c9a7f [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator Author

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

No test package could be found for tests on macOS M1 - Mac Big Sur (11.5)

Pipeline on Agent
Hash: ed3bf1276ee83e2e348be888bade364b5a4c9a7f [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator Author

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator Author

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
.NET (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: ed3bf1276ee83e2e348be888bade364b5a4c9a7f [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator Author

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 159 tests passed.

Failures

❌ framework tests

1 tests failed, 4 tests passed.
Details
  • framework-test/watchOS 32-bits - simulator/Debug: TimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 59 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 5 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 5 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 5 tests passed. Html Report (VSDrops) Download
✅ linker: All 38 tests passed. Html Report (VSDrops) Download
⚠️ mac_binding_project: No tests selected. Html Report (VSDrops) Download
⚠️ mmp: No tests selected. Html Report (VSDrops) Download
✅ mononative: All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 20 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
⚠️ xammac: No tests selected. Html Report (VSDrops) Download
✅ xcframework: All 5 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne

Copy link
Copy Markdown
Member

Test failure is unrelated (https://github.com/xamarin/maccore/issues/581).

@rolfbjarne
rolfbjarne merged commit b179676 into dotnet:release/7.0.1xx-xcode14-rc2 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported bug If an issue is a bug or a pull request a bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants