Skip to content

[tvos][videotoolbox] Enable VideoToolbox.framework on tvOS - #1626

Merged
spouliot merged 2 commits into
dotnet:xcode8.3from
spouliot:videotoolbox-tvos
Feb 3, 2017
Merged

[tvos][videotoolbox] Enable VideoToolbox.framework on tvOS#1626
spouliot merged 2 commits into
dotnet:xcode8.3from
spouliot:videotoolbox-tvos

Conversation

@spouliot

@spouliot spouliot commented Feb 2, 2017

Copy link
Copy Markdown
Contributor

This is just a build enablement to see xtro results. API adjustments,
including availability attributes, remains to be done.

This is just a build enablement to see xtro results. API adjustments,
including availability attributes, remains to be done.
@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

IntPtr.Zero,
fileUrl == null ? IntPtr.Zero : fileUrl.Handle,
timeRange ?? CMTimeRange.Invalid,
timeRange ?? CMTimeRange.InvalidRange,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch 👍

{
callbackHandle = GCHandle.Alloc (callback);
var foreachResult = VTFrameSiloCallFunctionForEachSampleBuffer (handle, range ?? CMTimeRange.Invalid, GCHandle.ToIntPtr (callbackHandle), static_EachSampleBufferCallback);
var foreachResult = VTFrameSiloCallFunctionForEachSampleBuffer (handle, range ?? CMTimeRange.InvalidRange, GCHandle.ToIntPtr (callbackHandle), static_EachSampleBufferCallback);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch 👍

IntPtr.Zero,
fileUrl == null ? IntPtr.Zero : fileUrl.Handle,
timeRange ?? CMTimeRange.Invalid,
timeRange ?? CMTimeRange.InvalidRange,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch 👍

@spouliot spouliot added the do-not-merge Do not merge this pull request label Feb 3, 2017
@spouliot

spouliot commented Feb 3, 2017

Copy link
Copy Markdown
Contributor Author

introspection - tvOS (Failed) - maybe the test needs adjustment ? because the API should be available. Needs some investigation before merging.

[FAIL] ApiCMAttachmentTest.CheckFailAttachments : System.InvalidOperationException : Could not create the new instance for type VTCompressionSession.

known failures:

@monojenkins

Copy link
Copy Markdown
Contributor

Build failure

@spouliot

spouliot commented Feb 3, 2017

Copy link
Copy Markdown
Contributor Author

known failure:

@spouliot spouliot removed the do-not-merge Do not merge this pull request label Feb 3, 2017
@spouliot
spouliot merged commit 7af0e34 into dotnet:xcode8.3 Feb 3, 2017
@spouliot
spouliot deleted the videotoolbox-tvos branch February 3, 2017 22:09
spouliot added a commit to spouliot/xamarin-macios that referenced this pull request Mar 28, 2017
This is just a build enablement to see xtro results. API adjustments,
including availability attributes, remains to be done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants