[mediaplayer] Update for iOS 10.3 beta 1 - #1627
Merged
Merged
Conversation
Contributor
Author
|
For: [Export ("insertQueueDescriptor:afterItem:")]
void InsertAfter (MPMusicPlayerQueueDescriptor queueDescriptor, [NullAllowed] MPMediaItem item);Guess we could also go |
spouliot
approved these changes
Feb 2, 2017
Contributor
|
Build failure |
dalexsoto
approved these changes
Feb 3, 2017
| NotSupported, | ||
| [iOS (10,1)] | ||
| Cancelled, | ||
| RequestTimedOut, |
Contributor
There was a problem hiding this comment.
@dalexsoto no, it's an error (output) enum so it's not needed. The one on Cancelled should be removed (not critical).
Contributor
Author
There was a problem hiding this comment.
Yes that's why I didn't add it.
Didn't want to remove the other one to not add noise.
rolfbjarne
approved these changes
Feb 3, 2017
MPMusicPlayerControllerMutableQueue and MPMusicPlayerControllerQueue's headers show no trace of NSCoding, NSSecureCoding or NSMutableCopying therefore we're skipping them.
spouliot
approved these changes
Feb 6, 2017
Contributor
|
Build failure |
Contributor
Author
|
Unrelated test failure:
|
spouliot
pushed a commit
to spouliot/xamarin-macios
that referenced
this pull request
Mar 28, 2017
* introspection-ios MPMusicPlayerControllerMutableQueue and MPMusicPlayerControllerQueue's headers show no trace of NSCoding, NSSecureCoding or NSMutableCopying therefore we're skipping them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.