[watchos][cloudkit] Update for beta 1 - #1659
Merged
Merged
Conversation
The CloudKit headers for watchOS were updated to match the ones from iOS and tvOS (from previous Xcode) so this mostly remove some watch specific code. Apple also made some previously broken `init` to be NS_DESIGNATED_INITIALIZER so those are now enabled for watchOS.
rolfbjarne
reviewed
Feb 8, 2017
| public partial class CKFetchNotificationChangesOperation { | ||
|
|
||
| // `init` does not work on watchOS but we can keep compatibility with a different init | ||
| public CKFetchNotificationChangesOperation () : this ((CKServerChangeToken) null) |
Member
There was a problem hiding this comment.
Won't this break code that's already using this constructor when that code runs on older watchOS versions - because on older watchOS you'll now call the broken init selector?
Contributor
Author
There was a problem hiding this comment.
@rolfbjarne Potentially (it's possible that the final 3.0 was fixed) but this fix subclassing :-|
I'll go back to see when it was fixed, I have 3.1.1 and 3.2b2 on hardware. Still have 3.0 around ? if not I'll check our database later
Member
There was a problem hiding this comment.
I just did this on my 3.0 device:
CKFetchNotificationChangesOperation *obj = [[CKFetchNotificationChangesOperation alloc] init];
NSLog (@"obj: %@", obj);
and it worked fine, so I guess this is OK.
Contributor
|
Build failure |
Contributor
Author
|
known failure
|
dalexsoto
approved these changes
Feb 10, 2017
spouliot
added a commit
to spouliot/xamarin-macios
that referenced
this pull request
Mar 28, 2017
The CloudKit headers for watchOS were updated to match the ones from iOS and tvOS (from previous Xcode) so this mostly remove some watch specific code. Apple also made some previously broken `init` to be NS_DESIGNATED_INITIALIZER so those are now enabled for watchOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CloudKit headers for watchOS were updated to match the ones from
iOS and tvOS (from previous Xcode) so this mostly remove some watch
specific code.
Apple also made some previously broken
initto beNS_DESIGNATED_INITIALIZER so those are now enabled for watchOS.