[UIKit] Fix properties in UIConfigurationColorTransformer Type

[haritha-mohan]

Changing properties to be internal
Fixes #16665

[github-actions]

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

[rolfbjarne]

This is a bit of a special case compared to the other fixes you've done.

These fields are supposed to be internal, and then manually exposed (without the underscore) here:

https://github.com/xamarin/xamarin-macios/blob/3b839e15514826b3bd6d61b953eb684c0c897116/src/UIKit/UIConfigurationColorTransformer.cs#L20-L39

but it seems the initial implementation forgot to make these fields internal (but still added the non-underscored public version).

That means the fix is to:

1. Make them internal in XAMCORE_5_0
2. Add an Obsolete attribute (in !XAMCORE_5_0) pointing to the non-underscore version (which already exists - see the code I linked to above).

In particular there's no need to add a new and correct implementation, because that already exists.

[vs-mobiletools-engineering-service2]

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

• iOS (no change detected)
• tvOS (no change detected)
• watchOS (no change detected)
• macOS (no change detected)

NET (empty diffs)

• iOS: (empty diff detected)
• tvOS: (empty diff detected)
• MacCatalyst: (empty diff detected)
• macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

• iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
• tvOS: vsdrops gist (No breaking changes)
• watchOS: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

• iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)
• Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

• iOS: vsdrops gist
• tvOS: vsdrops gist
• macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 38810e1f05ba540988e6e828f36ce5da101a751d [PR build]

[vs-mobiletools-engineering-service2]

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 38810e1f05ba540988e6e828f36ce5da101a751d [PR build]

[vs-mobiletools-engineering-service2]

📚 [PR Build] Artifacts 📚

Packages generated

View packages

• Microsoft.iOS.Bundle.16.1.568-ci.pr.gh16732.pkg
• Microsoft.iOS.Ref.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.iOS.Runtime.ios-arm.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.iOS.Runtime.ios-arm64.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.iOS.Runtime.iossimulator-arm64.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.iOS.Runtime.iossimulator-x64.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.iOS.Runtime.iossimulator-x86.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.iOS.Sdk.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.iOS.Templates.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.iOS.Windows.Sdk.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.MacCatalyst.Bundle.16.1.568-ci.pr.gh16732.pkg
• Microsoft.MacCatalyst.Ref.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-arm64.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-x64.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.MacCatalyst.Sdk.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.MacCatalyst.Templates.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.macOS.Bundle.13.0.1123-ci.pr.gh16732.pkg
• Microsoft.macOS.Ref.13.0.1123-ci.pr.gh16732.nupkg
• Microsoft.macOS.Runtime.osx-arm64.13.0.1123-ci.pr.gh16732.nupkg
• Microsoft.macOS.Runtime.osx-x64.13.0.1123-ci.pr.gh16732.nupkg
• Microsoft.macOS.Sdk.13.0.1123-ci.pr.gh16732.nupkg
• Microsoft.macOS.Templates.13.0.1123-ci.pr.gh16732.nupkg
• Microsoft.NET.Sdk.iOS.Manifest-7.0.100.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.NET.Sdk.MacCatalyst.Manifest-7.0.100.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.NET.Sdk.macOS.Manifest-7.0.100.13.0.1123-ci.pr.gh16732.nupkg
• Microsoft.NET.Sdk.tvOS.Manifest-7.0.100.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.NET.Workload.iOS.16.1.568-ci.pr.gh16732.msi
• Microsoft.tvOS.Bundle.16.1.568-ci.pr.gh16732.pkg
• Microsoft.tvOS.Ref.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.tvOS.Runtime.tvos-arm64.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-arm64.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-x64.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.tvOS.Sdk.16.1.568-ci.pr.gh16732.nupkg
• Microsoft.tvOS.Templates.16.1.568-ci.pr.gh16732.nupkg
• xamarin.ios-16.1.1.441.pkg
• xamarin.mac-9.0.0.441.pkg

Pipeline on Agent XAMBOT-1160.Monterey'
Hash: 38810e1f05ba540988e6e828f36ce5da101a751d [PR build]

[vs-mobiletools-engineering-service2]

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: $(GIT_HASH) [PR build]