[audiotoolbox] Remove null check on sourceAudioUnit - #1675
Merged
Conversation
PR#1667 changed some code to allow null SourceAudioUnit - but it forgot to remove the null check that throws an ArgumentNullException. Thanks to Tim for spotting this.
dalexsoto
approved these changes
Feb 10, 2017
Contributor
|
Build failure |
rolfbjarne
approved these changes
Feb 10, 2017
Contributor
Author
|
known issue:
|
spouliot
added a commit
to spouliot/xamarin-macios
that referenced
this pull request
Mar 28, 2017
PR#1667 changed some code to allow null SourceAudioUnit - but it forgot to remove the null check that throws an ArgumentNullException. Thanks to Tim for spotting this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1667 changed some code to allow null SourceAudioUnit - but it forgot
to remove the null check that throws an ArgumentNullException. Thanks
to Tim for spotting this.