Skip to content

[tests] Use a different identifier than '%...%' for replacement text. - #16762

Merged
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:tests-mac-text-replacement
Nov 16, 2022
Merged

[tests] Use a different identifier than '%...%' for replacement text.#16762
rolfbjarne merged 1 commit into
dotnet:mainfrom
rolfbjarne:tests-mac-text-replacement

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

When the autoformatter runs into the '%...%' pattern in *.cs files, it will
re-format the text (to '% ... %'), but that breaks our text replacement logic.
So instead use a valid C# identifier as a replacement token, in which case the
autoformatter won't confuse our replacement logic.

When the autoformatter runs into the '%...%' pattern in *.cs files, it will
re-format the text (to '% ... %'), but that breaks our text replacement logic.
So instead use a valid C# identifier as a replacement token, in which case the
autoformatter won't confuse our replacement logic.
@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: a7ef9791f816cfc101254f4221dca64795c2aa77 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: a7ef9791f816cfc101254f4221dca64795c2aa77 [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 2 tests failed, 221 tests passed.

Failures

❌ bcl tests

1 tests failed, 68 tests passed.
Details
  • [xUnit] Mono SystemCoreXunit Part 1/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

❌ fsharp tests

1 tests failed, 6 tests passed.
Details
  • fsharp/iOS Unified 64-bits - simulator/Debug: TimedOut

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: $(GIT_HASH) [PR build]

@rolfbjarne

Copy link
Copy Markdown
Member Author

Test failures are unrelated (https://github.com/xamarin/maccore/issues/581).

@rolfbjarne
rolfbjarne merged commit 86da9cc into dotnet:main Nov 16, 2022
@rolfbjarne
rolfbjarne deleted the tests-mac-text-replacement branch November 16, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants