Beta 1 Mac changes for ModelIO, SpriteKit, MediaPlayer by timrisi · Pull Request #1681 · dotnet/macios

timrisi · 2017-02-10T19:31:35Z

No description provided.

monojenkins · 2017-02-10T20:41:40Z

Build failure

VincentDondain · 2017-02-10T20:43:20Z

 		NSString PropertyIsLiveStream { get; }

-		[iOS (10,3)]
+		[iOS (10,3)][Mac (10, 12, 3)]


Minor no spaces between the versions for consistency (:

spouliot · 2017-02-10T20:41:16Z

+		[iOS (10,3), TV (10,2), Mac (10,12,4)]
+		[Export ("setObject:forKeyedSubscript:")]
+		void SetObject ([NullAllowed] IMDLComponent obj, Protocol key);
+


Check with @VincentDondain (or his PR) IIRC there was a reason for those not being there

Was about to comment: see #1601 (comment)

spouliot · 2017-02-10T20:41:22Z

+
+		[iOS (10,3), TV (10,2), Mac (10,12,4)]
+		[Export ("setObject:forKeyedSubscript:")]
+		void SetObject ([NullAllowed] IMDLComponent obj, Protocol key);


spouliot · 2017-02-10T20:45:52Z

+
 #if XAMCORE_4_0
-		[iOS (9,0), Mac(10,11)]
+		[iOS (10,0), Mac(10,12)]


We check those are runtime so, in general ours are better than Apple.
When/if updating them we need to dig up the truth about the API availability. That means, minimally confirming the new values as correct.

spouliot · 2017-02-10T20:46:00Z

 		SKAttributeValue GetValue (string key);

-		[iOS (9,0), Mac(10,11)]
+		[iOS (10,0), Mac(10,12)]


spouliot · 2017-02-10T20:46:15Z

+
 #if XAMCORE_4_0
-		[iOS (9,0), Mac(10,11)]
+		[iOS (10,0), Mac(10,12)]


spouliot · 2017-02-10T20:46:22Z

 		SKAttributeValue GetValue (string key);

-		[iOS (9,0), Mac(10,11)]
+		[iOS (10,0), Mac(10,12)]


spouliot · 2017-02-10T20:46:40Z

+
 #if XAMCORE_4_0
-		[iOS (9,0), Mac(10,11)]
+		[iOS (10,0), Mac(10,12)]


spouliot · 2017-02-10T20:46:45Z

 		SKAttributeValue GetValue (string key);

-		[iOS (9,0), Mac(10,11)]
+		[iOS (10,0), Mac(10,12)]


spouliot · 2017-02-10T20:46:51Z

+
 #if XAMCORE_4_0
-		[iOS (9,0), Mac(10,11)]
+		[iOS (10,0), Mac(10,12)]


spouliot · 2017-02-10T20:46:56Z

 		SKAttributeValue GetValue (string key);

-		[iOS (9,0), Mac(10,11)]
+		[iOS (10,0), Mac(10,12)]


VincentDondain · 2017-02-14T20:26:51Z

@timrisi alright so your MediaPlayer and SpriteKit changes are fine (except the availability attributes changes, see comments) but not the ModelIO ones, as we need to mark those selectors in xtro, see #1601 (comment)

Ideally this should become the SpriteKit PR and the 1 liner MediaPlayer availability attribute fix should go in a separate PR.

VincentDondain · 2017-02-14T21:35:11Z

After talking to @timrisi I'm gonna take over his work (thanks for the SpriteKit changes).

I'm actually gonna reuse his branch on his fork timrisi:xcode83-MacBeta1 but I will create a new PR as I'm making the changes SpriteKit only.

I PRed his MediaPlayer changes in a separate commit already here: #1693

ModelIO didn't change as explained but I added the xtro ignores here: #1692

Beta 1 Mac changes for ModelIO, SpriteKit, MediaPlayer

19039bb

dnfclas added the cla-already-signed label Feb 10, 2017

VincentDondain reviewed Feb 10, 2017

View reviewed changes

spouliot suggested changes Feb 10, 2017

View reviewed changes

spouliot assigned VincentDondain Feb 12, 2017

VincentDondain closed this Feb 14, 2017

Uh oh!

Conversation

timrisi commented Feb 10, 2017

Uh oh!

monojenkins commented Feb 10, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VincentDondain commented Feb 14, 2017

Uh oh!

VincentDondain commented Feb 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants