[dotnet] future proof the test - #17739
Merged
Merged
Conversation
stephen-hawley
added
not-notes-worthy
Contributor
|
rolfbjarne
approved these changes
Mar 7, 2023
dalexsoto
approved these changes
Mar 7, 2023
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
haritha-mohan
approved these changes
Mar 7, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Haritha Mohan <harithamohan@microsoft.com>
Co-authored-by: Haritha Mohan <harithamohan@microsoft.com>
Co-authored-by: Haritha Mohan <harithamohan@microsoft.com>
Co-authored-by: Haritha Mohan <harithamohan@microsoft.com>
Collaborator
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
Collaborator
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
Collaborator
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
Collaborator
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
Collaborator
Collaborator
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
Collaborator
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
Collaborator
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 84 tests failed, 141 tests passed. Failures❌ dotnettests tests [attempt 2]Details
Html Report (VSDrops) Download ❌ framework tests [attempt 2]Details
Html Report (VSDrops) Download ❌ interdependent_binding_projects tests [attempt 2]Details
Html Report (VSDrops) Download ❌ introspection tests [attempt 2]Details
Html Report (VSDrops) Download ❌ linker tests [attempt 2]Details
Html Report (VSDrops) Download ❌ monotouch tests [attempt 2]Details
Html Report (VSDrops) Download ❌ mtouch tests [attempt 2]Details
Html Report (VSDrops) Download ❌ xammac tests [attempt 2]Details
Html Report (VSDrops) Download ❌ xcframework tests [attempt 2]Details
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
mandel-macaque
approved these changes
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests fail, especially reflection based tests.
Wouldn't you like it if a test came with a blueprint on how to fix the issue you created? Yes, of course you would. So here it is.